[WEB-4477] fix: sidebar resize behaviour

[anmolsinghbhatia]

Description

The resize handler was calculating new width using absolute e.clientX values, which could cause jumps when the sidebar wasn't positioned at the left edge of the screen or had offsets.

Type of Change

• Bug fix

References

[WEB-4477]

Summary by CodeRabbit

• Refactor
  • Improved sidebar resizing behavior for smoother and more accurate adjustments.
  • Updated sidebar background color for visual consistency.

[coderabbitai]

Walkthrough

The sidebar resizing logic was refactored to use references for tracking the initial width and mouse position during a resize operation. The callback signatures and event handling were updated accordingly. Additionally, the sidebar's background color CSS class was changed in the component.

Changes

File(s)	Change Summary
apps/web/core/components/sidebar/resizable-sidebar.tsx	Refactored sidebar resize logic to use refs for initial width and mouse X, updated callback signatures, and changed sidebar background CSS class.

Suggested labels

🐛bug, 🌐frontend, ready_to_merge

Suggested reviewers

• vamsikrishnamathala
• prateekshourya29
• sriramveeraghanta

Poem

A sidebar that slides with a gentle new flow,
Ref logic in place, resizing just so.
Colors refreshed, events now precise,
With every small change, the UX feels nice.
🐇✨ Hopping along, the code’s looking bright—
Resize with delight, from morning to night!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5fbe411 and 1acdce8.

📒 Files selected for processing (1)

• apps/web/core/components/sidebar/resizable-sidebar.tsx (5 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: vineetk13
PR: makeplane/plane#6391
File: web/styles/react-day-picker.css:249-282
Timestamp: 2025-01-17T05:17:51.953Z
Learning: In the date range picker's CSS, left/right positioning for cell background effects (like in `.rdp-range_start::before`, `.rdp-range_middle::before`, `.rdp-range_end::before`) should use physical properties instead of logical properties, as these create visual effects that should remain consistent regardless of text direction.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Analyze (javascript)

🔇 Additional comments (6)

apps/web/core/components/sidebar/resizable-sidebar.tsx (6)

53-54: LGTM: Proper ref initialization for delta-based calculation.

The new refs correctly store the initial width and mouse X position needed for the delta-based resize calculation that fixes the jumping issue.

---

68-69: Excellent fix for the resize jumping issue!

The delta-based calculation correctly addresses the bug described in the PR objectives. Instead of using absolute e.clientX values that caused jumps when the sidebar had offsets, this now calculates the change in mouse position relative to the starting point and applies it to the initial width.

---

211-211: Background class change appears unrelated to the resize fix.

The change from bg-custom-background-100 to bg-custom-sidebar-background-100 seems to be a design consistency update rather than part of the resize bug fix. This is fine but should be noted as an additional change.

---

227-227: Correctly updated event handler to pass mouse event.

The onMouseDown handler now properly passes the mouse event to the startResizing callback, enabling the delta-based calculation.

---

285-285: Correctly updated peek view resize handler.

The peek view's resize handle is also properly updated to pass the mouse event, ensuring consistent behavior between the main sidebar and peek view.

---

75-82: Internal Handler Update—No Public API Change

The adjustment to startResizing (accepting the mouse event) is purely internal to ResizableSidebar (apps/web/core/components/sidebar/resizable-sidebar.tsx, around lines 75–82). This callback isn’t exposed via props, so no consuming code (e.g., in apps/web/app/(all)/[workspaceSlug]/(projects)/_sidebar.tsx) needs to be updated. You can ignore the breaking-change notice.

Likely an incorrect or invalid review comment.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[makeplane]

Pull Request Linked with Plane Work Items

• [WEB-4477] Resolve sidebar resize flicker by using relative mouse position

Comment Automatically Generated by Plane