[WEB-4471]fix: full screen view visibility#7387
Merged
Conversation
Contributor
WalkthroughThe changes introduce a dedicated DOM portal target for fullscreen UI elements by adding a new div with id "full-screen-portal" to the workspace layout. Several components—modals, Gantt chart root, and issue peek overview—are refactored to render their fullscreen content into this portal using React's Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UIComponent
participant FullScreenPortal
User->>UIComponent: Triggers fullscreen mode
UIComponent->>FullScreenPortal: Render content via createPortal
FullScreenPortal-->>User: Displays fullscreen content
User->>UIComponent: Exits fullscreen
UIComponent->>FullScreenPortal: Unmount content from portal
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Pull Request Linked with Plane Work Items Comment Automatically Generated by Plane |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
apps/web/app/(all)/[workspaceSlug]/(projects)/layout.tsx (1)
14-14: Consider addingh-fullfor explicit height coverageWhile
inset-0should handle the height, addingh-fullwould make the height coverage more explicit and consistent with the width specification.- <div id="full-screen-portal" className="inset-0 absolute w-full" /> + <div id="full-screen-portal" className="inset-0 absolute w-full h-full" />
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
apps/web/app/(all)/[workspaceSlug]/(projects)/layout.tsx(1 hunks)apps/web/core/components/analytics/work-items/modal/index.tsx(2 hunks)apps/web/core/components/gantt-chart/chart/root.tsx(3 hunks)apps/web/core/components/issues/peek-overview/view.tsx(3 hunks)
🧰 Additional context used
🧠 Learnings (2)
apps/web/core/components/gantt-chart/chart/root.tsx (1)
Learnt from: vamsikrishnamathala
PR: makeplane/plane#7061
File: web/core/components/workspace-notifications/root.tsx:18-18
Timestamp: 2025-05-14T13:16:23.323Z
Learning: In the Plane project codebase, the path alias `@/plane-web` resolves to the `ce` directory, making imports like `@/plane-web/hooks/use-notification-preview` correctly resolve to files in `web/ce/hooks/`.
apps/web/core/components/analytics/work-items/modal/index.tsx (1)
Learnt from: vamsikrishnamathala
PR: makeplane/plane#7061
File: web/core/components/workspace-notifications/root.tsx:18-18
Timestamp: 2025-05-14T13:16:23.323Z
Learning: In the Plane project codebase, the path alias `@/plane-web` resolves to the `ce` directory, making imports like `@/plane-web/hooks/use-notification-preview` correctly resolve to files in `web/ce/hooks/`.
🧬 Code Graph Analysis (3)
apps/web/core/components/gantt-chart/chart/root.tsx (1)
packages/utils/src/common.ts (1)
cn(8-8)
apps/web/core/components/analytics/work-items/modal/index.tsx (1)
packages/utils/src/common.ts (1)
cn(8-8)
apps/web/core/components/issues/peek-overview/view.tsx (1)
apps/space/core/components/issues/peek-overview/issue-details.tsx (1)
PeekOverviewIssueDetails(14-45)
anmolsinghbhatia
approved these changes
Jul 11, 2025
lifeiscontent
pushed a commit
that referenced
this pull request
Aug 18, 2025
* fix: full screen mode for analytics, work items peek and timeline chart * chore: added null check for portal elements
1 task
This was referenced Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This update fixes the full screen mode visibility for
Work items,Timeline Chart,Analytics.Type of Change
Summary by CodeRabbit
New Features
Refactor
Style