Skip to content

[WEB-4515] fix: duplicate work item quick action#7421

Merged
pushya22 merged 1 commit intopreviewfrom
fix-duplicate-work-item-quick-action
Jul 16, 2025
Merged

[WEB-4515] fix: duplicate work item quick action#7421
pushya22 merged 1 commit intopreviewfrom
fix-duplicate-work-item-quick-action

Conversation

@anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Jul 16, 2025

Description

This PR addresses the following:

  • Fixes flickering issue caused by duplicate work Item quick action in peek view.
  • Refactors code related to duplicate Work Item handling.

Type of Change

  • Bug fix
  • Code refactoring

Media

Before After
WEB-4515-Before WEB-4515-After

References

Work-item: [WEB-4515]

Summary by CodeRabbit

  • New Features

    • Enhanced the copy menu functionality to support an optional workspace identifier.
  • Bug Fixes

    • Improved issue detail modal behavior by preventing unnecessary fetching of issue details.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 16, 2025

Walkthrough

The changes introduce an optional workspaceSlug property to the CopyMenuHelperProps interface and propagate this parameter through related helper functions and hooks involved in issue quick-action dropdowns. Additionally, a new prop is passed to the CreateUpdateIssueModal component in the issue detail quick actions.

Changes

File(s) Change Summary
.../copy-menu-helper.tsx Added optional workspaceSlug property to CopyMenuHelperProps interface.
.../helper.tsx Updated createCopyMenuItem to accept and use optional workspaceSlug; propagated through hooks.
.../issue-detail.tsx Added fetchIssueDetails={false} prop to CreateUpdateIssueModal usage.

Possibly related PRs

Suggested labels

🐛bug, 🧹chore, 🌐frontend

Suggested reviewers

  • prateekshourya29
  • vamsikrishnamathala
  • sriramveeraghanta

Poem

A slug for the workspace, so nimble and neat,
Now passed through the helpers, a seamless feat.
Quick actions align, as dropdowns appear,
With modals refreshed, the intent is clear.
A hop and a skip, the code’s in good cheer! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3224122 and cf73256.

📒 Files selected for processing (3)
  • apps/web/ce/components/issues/issue-layouts/quick-action-dropdowns/copy-menu-helper.tsx (1 hunks)
  • apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/helper.tsx (3 hunks)
  • apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/issue-detail.tsx (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/issue-detail.tsx (1)
Learnt from: vamsikrishnamathala
PR: makeplane/plane#7214
File: web/core/store/issue/helpers/base-issues.store.ts:117-117
Timestamp: 2025-06-16T07:23:39.497Z
Learning: In the updateIssueDates method of BaseIssuesStore (web/core/store/issue/helpers/base-issues.store.ts), the projectId parameter is intentionally made optional to support override implementations in subclasses. The base implementation requires projectId and includes an early return check, but making it optional allows derived classes to override the method with different parameter requirements.
🧬 Code Graph Analysis (1)
apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/helper.tsx (1)
packages/ui/src/dropdowns/context-menu/root.tsx (1)
  • TContextMenuItem (12-25)
🔇 Additional comments (5)
apps/web/ce/components/issues/issue-layouts/quick-action-dropdowns/copy-menu-helper.tsx (1)

15-15: LGTM: Clean interface extension for workspace context support.

The addition of the optional workspaceSlug property properly extends the interface to support workspace-aware functionality while maintaining backward compatibility.

apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/issue-detail.tsx (1)

220-220: LGTM: Targeted fix for flickering issue.

Adding fetchIssueDetails={false} properly addresses the flickering issue by preventing unnecessary data fetching in the modal, which aligns with the PR objective.

apps/web/core/components/issues/issue-layouts/quick-action-dropdowns/helper.tsx (3)

167-167: LGTM: Clean function signature update.

The addition of the optional workspaceSlug parameter properly extends the function to support workspace-aware functionality while maintaining backward compatibility.


183-183: LGTM: Consistent parameter passing.

The workspaceSlug parameter is properly threaded through to the createCopyMenuWithDuplication function, maintaining consistency with the interface changes.


283-283: LGTM: Proper parameter propagation.

The props.workspaceSlug is correctly passed to createCopyMenuItem, completing the parameter threading chain for workspace context support.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@makeplane
Copy link

makeplane bot commented Jul 16, 2025

Pull Request Linked with Plane Work Items

Comment Automatically Generated by Plane

@pushya22 pushya22 merged commit 89983b0 into preview Jul 16, 2025
5 of 6 checks passed
@pushya22 pushya22 deleted the fix-duplicate-work-item-quick-action branch July 16, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants