[WEB-4507] fix: webhooks translation#7424
Conversation
WalkthroughThe translation keys used in the Changes
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Pull Request Linked with Plane Work Items Comment Automatically Generated by Plane |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/web/core/components/web-hooks/generated-hook-details.tsx (1)
30-32: Internationalise the “Close” label for consistencyAll visible strings in this modal are now translation-driven except the “Close” button.
Switching it tot("common.close")(or whatever key is already used elsewhere) keeps UX consistent and avoids hard-coded English.- <Button variant="neutral-primary" size="sm" onClick={handleClose}> - Close - </Button> + <Button variant="neutral-primary" size="sm" onClick={handleClose}> + {t("common.close")} + </Button>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/web/core/components/web-hooks/generated-hook-details.tsx(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: janreges
PR: makeplane/plane#6743
File: packages/i18n/src/store/index.ts:160-161
Timestamp: 2025-03-11T19:42:41.769Z
Learning: In the Plane project, the file 'packages/i18n/src/store/index.ts' already includes support for Polish language translations with the case "pl".
Learnt from: vamsikrishnamathala
PR: makeplane/plane#7092
File: web/core/components/issues/issue-detail-widgets/sub-issues/issues-list/root.tsx:109-113
Timestamp: 2025-05-22T11:21:49.370Z
Learning: Both translation keys "sub_work_item.empty_state.list_filters.action" and "sub_work_item.empty_state.sub_list_filters.action" have identical values across all language files in the Plane project, so they can be used interchangeably.
🧬 Code Graph Analysis (1)
apps/web/core/components/web-hooks/generated-hook-details.tsx (1)
packages/i18n/src/store/index.ts (1)
t(211-232)
🔇 Additional comments (1)
apps/web/core/components/web-hooks/generated-hook-details.tsx (1)
24-25: Translation keys verified across all localesAll
packages/i18n/src/locales/*/translations.jsonfiles contain both
workspace_settings.key_createdandworkspace_settings.copy_key. No missing keys detected—this change is safe.
4 participants
Description
This PR fixes a translation issue in the Webhooks modal.
Type of Change
Media
References
Work-item: [WEB-4507]
Summary by CodeRabbit