[WIKI-554] feat: delete multiple rows/columns from a table

packages/editor/src/core/extensions/table/plugins/insert-handlers/utils.ts

@@ -1,6 +1,8 @@
 import type { Editor } from "@tiptap/core";
 import type { Node as ProseMirrorNode } from "@tiptap/pm/model";
 import { addColumn, removeColumn, addRow, removeRow, TableMap } from "@tiptap/pm/tables";
+// local imports
+import { isCellEmpty } from "../../table/utilities/helpers";
 
 const addSvg = `<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
 <path
@@ -319,27 +321,6 @@ const removeLastColumn = (editor: Editor, tableInfo: TableInfo): boolean => {
   return true;
 };
 
-// Helper function to check if a single cell is empty
-const isCellEmpty = (cell: ProseMirrorNode | null | undefined): boolean => {
-  if (!cell || cell.content.size === 0) {
-    return true;
-  }
-
-  // Check if cell has any non-empty content
-  let hasContent = false;
-  cell.content.forEach((node) => {
-    if (node.type.name === "paragraph") {
-      if (node.content.size > 0) {
-        hasContent = true;
-      }
-    } else if (node.content.size > 0 || node.isText) {
-      hasContent = true;
-    }
-  });
-
-  return !hasContent;
-};
-
 const isColumnEmpty = (tableInfo: TableInfo, columnIndex: number): boolean => {
   const { tableNode } = tableInfo;
   const tableMapData = TableMap.get(tableNode);

packages/editor/src/core/extensions/table/plugins/selection-outline/plugin.ts

@@ -1,8 +1,9 @@
 import { findParentNode, type Editor } from "@tiptap/core";
 import { Plugin, PluginKey } from "@tiptap/pm/state";
-import { CellSelection, TableMap } from "@tiptap/pm/tables";
+import { TableMap } from "@tiptap/pm/tables";
 import { Decoration, DecorationSet } from "@tiptap/pm/view";
 // local imports
+import { isCellSelection } from "../../table/utilities/helpers";
 import { getCellBorderClasses } from "./utils";
 
 type TableCellSelectionOutlinePluginState = {
@@ -25,7 +26,7 @@ export const TableCellSelectionOutlinePlugin = (editor: Editor): Plugin<TableCel
         }
 
         const { selection } = newState;
-        if (!(selection instanceof CellSelection)) return {};
+        if (!isCellSelection(selection)) return {};
 
         const decorations: Decoration[] = [];
         const tableMap = TableMap.get(table.node);

packages/editor/src/core/extensions/table/table/table-view.tsx

@@ -7,6 +7,8 @@ import { icons } from "src/core/extensions/table/table/icons";
 import tippy, { Instance, Props } from "tippy.js";
 // constants
 import { CORE_EXTENSIONS } from "@/constants/extension";
+// local imports
+import { isCellSelection } from "./utilities/helpers";
 
 type ToolboxItem = {
   label: string;
@@ -95,7 +97,7 @@ function setCellsBackgroundColor(editor: Editor, color: { backgroundColor: strin
 function setTableRowBackgroundColor(editor: Editor, color: { backgroundColor: string; textColor: string }) {
   const { state, dispatch } = editor.view;
   const { selection } = state;
-  if (!(selection instanceof CellSelection)) {
+  if (!isCellSelection(selection)) {
     return false;
   }
 

packages/editor/src/core/extensions/table/table/table.ts

@@ -26,8 +26,8 @@ import { tableControls } from "./table-controls";
 import { TableView } from "./table-view";
 import { createTable } from "./utilities/create-table";
 import { deleteColumnOrTable } from "./utilities/delete-column";
+import { handleDeleteKeyOnTable } from "./utilities/delete-key-shortcut";
 import { deleteRowOrTable } from "./utilities/delete-row";
-import { deleteTableWhenAllCellsSelected } from "./utilities/delete-table-when-all-cells-selected";
 import { insertLineAboveTableAction } from "./utilities/insert-line-above-table-action";
 import { insertLineBelowTableAction } from "./utilities/insert-line-below-table-action";
 import { DEFAULT_COLUMN_WIDTH } from ".";
@@ -236,10 +236,10 @@ export const Table = Node.create<TableOptions>({
         return false;
       },
       "Shift-Tab": () => this.editor.commands.goToPreviousCell(),
-      Backspace: deleteTableWhenAllCellsSelected,
-      "Mod-Backspace": deleteTableWhenAllCellsSelected,
-      Delete: deleteTableWhenAllCellsSelected,
-      "Mod-Delete": deleteTableWhenAllCellsSelected,
+      Backspace: handleDeleteKeyOnTable,
+      "Mod-Backspace": handleDeleteKeyOnTable,
+      Delete: handleDeleteKeyOnTable,
+      "Mod-Delete": handleDeleteKeyOnTable,
       ArrowDown: insertLineBelowTableAction,
       ArrowUp: insertLineAboveTableAction,
     };