Skip to content

[WIKI-357] fix: created by filter for pages list#7445

Merged
pushya22 merged 1 commit intopreviewfrom
fix/created-by-filter
Jul 21, 2025
Merged

[WIKI-357] fix: created by filter for pages list#7445
pushya22 merged 1 commit intopreviewfrom
fix/created-by-filter

Conversation

@aaryan610
Copy link
Copy Markdown
Member

@aaryan610 aaryan610 commented Jul 18, 2025

Description

This PR fixes the bug where created by filter isn't working for a few pages.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

  • Bug Fixes
    • Improved page filtering to use the page's owner when applying the "created by" filter, ensuring more accurate results when filtering by creator.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jul 18, 2025

Walkthrough

The change updates the filtering logic in the shouldFilterPage function so that filtering by the "created_by" key now uses the page's owned_by property instead of the created_by property. No other logic or exported interfaces are affected.

Changes

File(s) Change Summary
packages/utils/src/page.ts Modified shouldFilterPage to filter by owned_by instead of created_by when using the "created_by" filter key.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Utils (page.ts)
    participant Page

    Caller->>Utils (page.ts): shouldFilterPage(page, filters)
    Utils (page.ts)->>Page: Access page.owned_by
    Utils (page.ts)-->>Caller: Returns filter result based on owned_by
Loading

Possibly related PRs

Suggested labels

ready to merge

Suggested reviewers

  • Palanikannan1437

Poem

A bunny hopped through fields of code,
Where filters once by creator strode.
Now owners lead the page parade,
With logic in the utils laid.
A gentle tweak, a subtle tune—
Ownership shines beneath the moon!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5660b28 and b766e1c.

📒 Files selected for processing (1)
  • packages/utils/src/page.ts (1 hunks)
🔇 Additional comments (1)
packages/utils/src/page.ts (1)

63-64: Confirm “Created by” filter uses page.owned_by

The change to use page.owned_by instead of page.created_by for the "created_by" filter in packages/utils/src/page.ts appears intentional—it matches the API’s page payload, which exposes the current owner as owned_by when listing pages. Before merging, please double-check:

  • That the UI label “Created by” should indeed map to the page’s owner field, not the original creator.
  • That the TPage type (in packages/types/src/page/core.ts) includes owned_by and that consumers expect filtering on that property.

Locations to review:

  • packages/utils/src/page.ts ➔ lines 63–64 (filterKey "created_by")
  • packages/types/src/page/core.ts ➔ confirm TPage (or its interface) defines owned_by
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@makeplane
Copy link
Copy Markdown

makeplane bot commented Jul 18, 2025

Pull Request Linked with Plane Work Items

Comment Automatically Generated by Plane

@pushya22 pushya22 merged commit cc673a1 into preview Jul 21, 2025
5 of 6 checks passed
@pushya22 pushya22 deleted the fix/created-by-filter branch July 21, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants