Skip to content

Comments

[WEB-4552] fix: stickies layout + minified layout filter#7466

Merged
sriramveeraghanta merged 1 commit intopreviewfrom
chore-home-fixes
Jul 24, 2025
Merged

[WEB-4552] fix: stickies layout + minified layout filter#7466
sriramveeraghanta merged 1 commit intopreviewfrom
chore-home-fixes

Conversation

@gakshita
Copy link
Collaborator

@gakshita gakshita commented Jul 23, 2025

Description

  • Stickies layout fixed for bigger screen widths
  • Minified layout filter text + options fixed

Summary by CodeRabbit

  • New Features

    • Added SPREADSHEET and GANTT layout options to the mobile layout selector for both project and module issue views, making mobile layout choices consistent with desktop.
  • Enhancements

    • Improved mobile layout selection menu by updating the displayed text for each layout option.
    • Enhanced the stickies layout with a more responsive column count, providing better adaptability across different screen widths.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 23, 2025

Walkthrough

The updates expand layout options in mobile selectors to include SPREADSHEET and GANTT, align label rendering with a new property, and enhance responsive column logic in sticky layouts. Additionally, the type definition for issue layouts now includes an i18n_label property for consistency across components.

Changes

File(s) Change Summary
.../cycles/(detail)/header.tsx
.../modules/(detail)/header.tsx
Expanded mobile layout selection options to include SPREADSHEET and GANTT, matching desktop layout options.
.../issue-layouts/filters/header/mobile-layout-selection.tsx Changed label rendering to use i18n_label instead of i18n_title for layout options.
.../stickies/layout/stickies-list.tsx Enhanced responsive logic for sticky layout columns with more granular breakpoints and updated defaults.
packages/constants/src/issue/layout.ts Updated ISSUE_LAYOUTS type to include a new i18n_label property.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MobileLayoutSelection
    participant LayoutConstants

    User->>MobileLayoutSelection: Open layout selector
    MobileLayoutSelection->>LayoutConstants: Fetch ISSUE_LAYOUTS (with i18n_label)
    MobileLayoutSelection-->>User: Display all layout options (LIST, KANBAN, CALENDAR, SPREADSHEET, GANTT) with i18n_label
    User->>MobileLayoutSelection: Select layout
    MobileLayoutSelection-->>User: Apply selected layout
Loading

Estimated code review effort

2 (~15 minutes)

Suggested labels

🌐frontend, 🎨UI / UX, 🐛bug, ready to merge

Suggested reviewers

  • prateekshourya29

Poem

Five layouts now for mobile view,
With labels clear and columns new.
Stickies stretch as screens expand,
Spreadsheet, Gantt, all close at hand.
A hop, a skip, a code review—
The rabbit cheers these changes through! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d2629d7 and 3140f25.

📒 Files selected for processing (5)
  • apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/cycles/(detail)/header.tsx (1 hunks)
  • apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/modules/(detail)/header.tsx (1 hunks)
  • apps/web/core/components/issues/issue-layouts/filters/header/mobile-layout-selection.tsx (1 hunks)
  • apps/web/core/components/stickies/layout/stickies-list.tsx (1 hunks)
  • packages/constants/src/issue/layout.ts (1 hunks)
🧠 Learnings (3)
📓 Common learnings
Learnt from: vineetk13
PR: makeplane/plane#6391
File: web/styles/react-day-picker.css:249-282
Timestamp: 2025-01-17T05:17:51.953Z
Learning: In the date range picker's CSS, left/right positioning for cell background effects (like in `.rdp-range_start::before`, `.rdp-range_middle::before`, `.rdp-range_end::before`) should use physical properties instead of logical properties, as these create visual effects that should remain consistent regardless of text direction.
packages/constants/src/issue/layout.ts (1)

Learnt from: mathalav55
PR: #6452
File: web/helpers/issue.helper.ts:6-6
Timestamp: 2025-01-24T09:37:19.339Z
Learning: In the Plane codebase, ISSUE_DISPLAY_FILTERS_BY_LAYOUT and ISSUE_DISPLAY_FILTERS_BY_PAGE are two distinct constants serving different purposes - one for layout-level filters and another for page-level filters. They are not interchangeable and should coexist.

apps/web/core/components/issues/issue-layouts/filters/header/mobile-layout-selection.tsx (1)

Learnt from: mathalav55
PR: #6452
File: web/helpers/issue.helper.ts:6-6
Timestamp: 2025-01-24T09:37:19.339Z
Learning: In the Plane codebase, ISSUE_DISPLAY_FILTERS_BY_LAYOUT and ISSUE_DISPLAY_FILTERS_BY_PAGE are two distinct constants serving different purposes - one for layout-level filters and another for page-level filters. They are not interchangeable and should coexist.

🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: vineetk13
PR: makeplane/plane#6391
File: web/styles/react-day-picker.css:249-282
Timestamp: 2025-01-17T05:17:51.953Z
Learning: In the date range picker's CSS, left/right positioning for cell background effects (like in `.rdp-range_start::before`, `.rdp-range_middle::before`, `.rdp-range_end::before`) should use physical properties instead of logical properties, as these create visual effects that should remain consistent regardless of text direction.
packages/constants/src/issue/layout.ts (1)

Learnt from: mathalav55
PR: #6452
File: web/helpers/issue.helper.ts:6-6
Timestamp: 2025-01-24T09:37:19.339Z
Learning: In the Plane codebase, ISSUE_DISPLAY_FILTERS_BY_LAYOUT and ISSUE_DISPLAY_FILTERS_BY_PAGE are two distinct constants serving different purposes - one for layout-level filters and another for page-level filters. They are not interchangeable and should coexist.

apps/web/core/components/issues/issue-layouts/filters/header/mobile-layout-selection.tsx (1)

Learnt from: mathalav55
PR: #6452
File: web/helpers/issue.helper.ts:6-6
Timestamp: 2025-01-24T09:37:19.339Z
Learning: In the Plane codebase, ISSUE_DISPLAY_FILTERS_BY_LAYOUT and ISSUE_DISPLAY_FILTERS_BY_PAGE are two distinct constants serving different purposes - one for layout-level filters and another for page-level filters. They are not interchangeable and should coexist.

🔇 Additional comments (5)
packages/constants/src/issue/layout.ts (1)

65-65: LGTM! Type definition correctly aligned with data structure.

The addition of i18n_label to the ISSUE_LAYOUTS type aligns it with the existing ISSUE_LAYOUT_MAP structure, ensuring type safety for components that use layout labels.

apps/web/core/components/stickies/layout/stickies-list.tsx (1)

184-192: Enhanced responsive column logic improves layout adaptability.

The more granular breakpoints (640px, 850px, 1024px, 1280px) with corresponding column counts (2-6) provide better responsive behavior across different screen sizes. The updated default of 4 columns is a reasonable middle ground when width is unavailable.

apps/web/core/components/issues/issue-layouts/filters/header/mobile-layout-selection.tsx (1)

49-49: LGTM! Appropriate use of label text for mobile UI.

Switching from i18n_title to i18n_label is appropriate for mobile layout selection, as labels are typically more concise than titles, better fitting mobile UI constraints.

apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/modules/(detail)/header.tsx (1)

222-228: Excellent! Mobile layout options now match desktop functionality.

Adding SPREADSHEET and GANTT layouts to the mobile selector achieves parity with the desktop layout options, ensuring consistent user experience across all devices.

apps/web/app/(all)/[workspaceSlug]/(projects)/projects/(detail)/[projectId]/cycles/(detail)/header.tsx (1)

231-237: Perfect consistency! Mobile layout options unified across cycles and modules.

Expanding the mobile layout selection to include SPREADSHEET and GANTT ensures feature parity with desktop and maintains consistency with the modules header component.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pushya22 pushya22 changed the title fix: stickies layout + minified layout filter [WEB-4552] fix: stickies layout + minified layout filter Jul 23, 2025
@makeplane
Copy link

makeplane bot commented Jul 23, 2025

Pull Request Linked with Plane Work Items

Comment Automatically Generated by Plane

@sriramveeraghanta sriramveeraghanta merged commit 3c6e2b4 into preview Jul 24, 2025
5 of 6 checks passed
@sriramveeraghanta sriramveeraghanta deleted the chore-home-fixes branch July 24, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants