Skip to content

[WIKI-565] chore: handle 404 messages in live server#7472

Merged
sriramveeraghanta merged 2 commits intopreviewfrom
fix-live-404-handler
Jul 24, 2025
Merged

[WIKI-565] chore: handle 404 messages in live server#7472
sriramveeraghanta merged 2 commits intopreviewfrom
fix-live-404-handler

Conversation

@sriramveeraghanta
Copy link
Member

@sriramveeraghanta sriramveeraghanta commented Jul 24, 2025

Description

  • handle 404 messages in live server

Type of Change

  • Improvement (change that would cause existing functionality to not work as expected)

Summary by CodeRabbit

  • Chores

    • Added a new example environment variable for configuring the server port.
  • Bug Fixes

    • Standardized error responses to use JSON format for internal server errors and 404 not found cases.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 24, 2025

Walkthrough

The changes introduce a new PORT variable in the environment example file and standardize error responses in the server code to use JSON format for both 500 and 404 errors in the /convert-document endpoint and the catch-all route.

Changes

File(s) Change Summary
apps/live/.env.example Added PORT=3100 to the environment example file.
apps/live/src/server.ts Modified error handling to respond with JSON for 500 and 404 errors.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A port is set, the server's clear,
JSON errors now appear.
No more text for "Not Found" woes,
Structured data gently flows.
Rabbits cheer with fluffy might,
For tidy code and outputs right!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ff80d8c and 7448b3b.

📒 Files selected for processing (1)
  • apps/live/src/server.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/live/src/server.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-live-404-handler

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
apps/live/.env.example (1)

1-1: Add a short note explaining the new port

PORT=3100 is clear to us now, but future readers glancing at this file might not realise this is the port the Live server binds to (as opposed to WEB_BASE_URL / API_BASE_URL). A brief inline comment will avoid confusion.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2746bad and ff80d8c.

📒 Files selected for processing (2)
  • apps/live/.env.example (1 hunks)
  • apps/live/src/server.ts (1 hunks)
🔇 Additional comments (1)
apps/live/src/server.ts (1)

91-94: Consistent, client-friendly 404 response – looks good

Switching the catch-all handler to structured JSON keeps the API uniform and simplifies consumer code.

@sriramveeraghanta sriramveeraghanta changed the title chore: handle 404 messages in live server [WIKI-565] chore: handle 404 messages in live server Jul 24, 2025
@sriramveeraghanta sriramveeraghanta merged commit 849b7b7 into preview Jul 24, 2025
5 of 6 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-live-404-handler branch July 24, 2025 09:43
@makeplane
Copy link

makeplane bot commented Jul 24, 2025

Pull Request Linked with Plane Work Items

Comment Automatically Generated by Plane

lifeiscontent pushed a commit that referenced this pull request Aug 18, 2025
* chore: handle 404 messages in live server

* chore: removed error stack from response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants