fix: CI to include lint and format#7482
Conversation
The web app takes too long and causes CI to timeout. Once we improve we will reintroduce.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... 📒 Files selected for processing (27)
WalkthroughThe updates introduce a new npm script for CI builds, adjust the GitHub Actions workflow to use this script and reorder linting and build steps, and correct an import path in a TypeScript file. No changes were made to exported or public entities beyond the new script. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Poem
Tip You can disable poems in the walkthrough.Disable the ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
package.json (1)
19-21:ci:buildscript added – confirm the filter behaves as expected
turbo run build --filter=!webwill skip thewebworkspace only if no downstream projects depend on it.
If any package depends onweb, Turbo will still build it.
Double-check the dependency graph; if you truly need to force-skip the build you may have to movewebinto anignoredscope or adjust the pipeline..github/workflows/pull-request-build-lint-web-apps.yml (1)
40-41: Step name no longer reflects what’s builtThe job is titled “Build and lint web apps”, yet the new command excludes
web.
Consider renaming the step (and possibly the workflow) to avoid misleading status checks while the exclusion is in place.- - name: Build apps + - name: Build (excluding web)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/pull-request-build-lint-web-apps.yml(1 hunks)package.json(1 hunks)packages/editor/src/core/extensions/table/table/table-view.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Build and lint web apps
- GitHub Check: Analyze (javascript)
- GitHub Check: Build and lint web apps
🔇 Additional comments (1)
packages/editor/src/core/extensions/table/table/table-view.tsx (1)
7-9: Import-path fix verified:icons.tsis present
- Confirmed
packages/editor/src/core/extensions/table/table/icons.tsexists alongsidetable-view.tsx.The switch to the local
./iconsimport is safe and will resolve correctly at runtime. 👍
Description
editorlint check passing againlintstep first during CIType of Change
Summary by CodeRabbit