[WEB-4585]chore: updated new brand fav icon#7493
[WEB-4585]chore: updated new brand fav icon#7493vamsikrishnamathala wants to merge 1 commit intopreviewfrom
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Pull Request Linked with Plane Work Items
Comment Automatically Generated by Plane |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
apps/web/public/favicon/site.webmanifest (1)
1-1: Populatename/short_namefor better PWA install UX
Both fields are empty, so an installed PWA will show a blank label on the home screen. Consider setting them to something like"Plane"and"Plane".apps/admin/public/favicon/site.webmanifest (1)
1-1: Minified JSON hurts readability & omits trailing newline
Minification offers negligible size benefit for a 270 B file but makes diffs noisy. Keeping the pretty-printed layout (or at least a trailing newline) aids future edits and keeps the repo POSIX-friendly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (18)
apps/admin/public/favicon/android-chrome-192x192.pngis excluded by!**/*.pngapps/admin/public/favicon/android-chrome-512x512.pngis excluded by!**/*.pngapps/admin/public/favicon/apple-touch-icon.pngis excluded by!**/*.pngapps/admin/public/favicon/favicon-16x16.pngis excluded by!**/*.pngapps/admin/public/favicon/favicon-32x32.pngis excluded by!**/*.pngapps/admin/public/favicon/favicon.icois excluded by!**/*.icoapps/space/public/favicon/android-chrome-192x192.pngis excluded by!**/*.pngapps/space/public/favicon/android-chrome-512x512.pngis excluded by!**/*.pngapps/space/public/favicon/apple-touch-icon.pngis excluded by!**/*.pngapps/space/public/favicon/favicon-16x16.pngis excluded by!**/*.pngapps/space/public/favicon/favicon-32x32.pngis excluded by!**/*.pngapps/space/public/favicon/favicon.icois excluded by!**/*.icoapps/web/public/favicon/android-chrome-192x192.pngis excluded by!**/*.pngapps/web/public/favicon/android-chrome-512x512.pngis excluded by!**/*.pngapps/web/public/favicon/apple-touch-icon.pngis excluded by!**/*.pngapps/web/public/favicon/favicon-16x16.pngis excluded by!**/*.pngapps/web/public/favicon/favicon-32x32.pngis excluded by!**/*.pngapps/web/public/favicon/favicon.icois excluded by!**/*.ico
📒 Files selected for processing (2)
apps/admin/public/favicon/site.webmanifest(1 hunks)apps/web/public/favicon/site.webmanifest(1 hunks)
c2cde70 to
364479c
Compare
Description
This update adds the new brand fav icon to all the three apps. Admin, Space and Web.
Type of Change
Summary by CodeRabbit
Style
Chores