[WIKI-577] fix: unexpected emoji input

[iam-vipin]

Description

After inputing : when someone press enter its considered as a emoji input and enter and default emoji its now fixed to add proper check before doing insertion

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

Screenshots and Media (if applicable)

Screen.Recording.2025-08-02.at.9.29.00.PM.mov

Test Scenarios

References

Summary by CodeRabbit

• Bug Fixes
  • Improved emoji list keyboard navigation by preventing key handling when the search query is empty.

[coderabbitai]

Walkthrough

The handleKeyDown function in the EmojiList component was updated to return early if the query string is empty and its dependency array was modified to include query.length. No changes were made to public or exported entity signatures.

Changes

Cohort / File(s)	Change Summary
EmojiList Key Handling Logic packages/editor/src/core/extensions/emoji/components/emojis-list.tsx	Modified handleKeyDown to return early if query is empty; updated hook dependencies to include query.length.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant EmojiList
    User->>EmojiList: KeyDown event
    EmojiList->>EmojiList: Check query.length
    alt query.length <= 0
        EmojiList-->>User: Return false (no further action)
    else query.length > 0
        EmojiList->>EmojiList: Continue key handling logic
    end

Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• [WIKI-521] fix : emoji unexpectedly scroll #7344: Also refactors handleKeyDown logic and related UI behavior in the same component, indicating a strong connection in keyboard event handling.

Suggested labels

🐛bug, ✍️editor, ready to merge

Suggested reviewers

• aaryan610

Poem

In the land of code where emojis play,
A rabbit hops in, smoothing the way.
If the query is empty, we halt the spree—
No more wild keys, just let it be!
With dependencies tidy and logic tight,
Our emoji picker now feels just right.
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 784b8da and 28eefa2.

📒 Files selected for processing (1)

• packages/editor/src/core/extensions/emoji/components/emojis-list.tsx (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: Build and lint web apps
• GitHub Check: Build and lint web apps
• GitHub Check: Build and lint web apps
• GitHub Check: Analyze (javascript)

🔇 Additional comments (2)

packages/editor/src/core/extensions/emoji/components/emojis-list.tsx (2)

64-66: LGTM! Fixes the unexpected emoji insertion issue.

The early return when query.length <= 0 correctly prevents keyboard event handling when there's no query text, which directly addresses the PR objective of fixing unexpected emoji input when pressing Enter after just a colon.

---

92-92: LGTM! Correctly updates dependency array.

Adding query.length to the dependency array is necessary since the callback now references it in the early return condition. This follows React hooks best practices and prevents stale closure issues.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-unexpected_emoji_input

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[makeplane]

Pull Request Linked with Plane Work Items

• [WIKI-577] Fix unexpected Emoji input

Comment Automatically Generated by Plane