Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
eb67946
chore: global css file added to tailwind config package
anmolsinghbhatia Aug 21, 2025
583cb4d
chore: tailwind config updated
anmolsinghbhatia Aug 21, 2025
a145246
chore: cn utility function added to propel package
anmolsinghbhatia Aug 21, 2025
4914fb3
chore: storybook init
anmolsinghbhatia Aug 21, 2025
fb385ea
fix: format error
anmolsinghbhatia Aug 21, 2025
8aac784
feat: added base ui tabs
JayashTripathy Aug 21, 2025
6094bdf
fix: add missing newline at end of package.json in propel package
JayashTripathy Aug 21, 2025
f163f41
fix: reorder import statement for Tabs component in propel package
JayashTripathy Aug 21, 2025
3d46363
feat: refactor Tabs component to support compound structure with forw…
JayashTripathy Aug 21, 2025
93faef4
fix: lint
JayashTripathy Aug 21, 2025
77aee58
chore: code refactor
anmolsinghbhatia Aug 22, 2025
250b534
chore: code refactor
anmolsinghbhatia Aug 22, 2025
309ec18
Merge remote-tracking branch 'origin/chore-propel-storybook-setup' in…
JayashTripathy Aug 24, 2025
220da47
fix: lock file
JayashTripathy Aug 24, 2025
2b5a07d
chore: added stories for tabs
JayashTripathy Aug 24, 2025
72d396e
refactor: clean up
JayashTripathy Aug 24, 2025
66126ef
Merge remote-tracking branch 'origin/preview' into feat-propel-tabs
JayashTripathy Aug 28, 2025
15bd65c
fix: lint
JayashTripathy Aug 28, 2025
fe380c4
fix: lint
JayashTripathy Aug 28, 2025
c9f2711
fix: Remove duplicate storybook ESLint config
JayashTripathy Aug 28, 2025
5efa5eb
Merge remote-tracking branch 'origin/preview' into feat-propel-tabs
JayashTripathy Aug 28, 2025
4538421
Merge branch 'feat-propel-tabs' of https://github.com/makeplane/plane…
JayashTripathy Aug 28, 2025
2f8127e
fix: lint
JayashTripathy Aug 28, 2025
728bd23
fix: update classname import path in Tabs component
JayashTripathy Aug 28, 2025
991d949
fix: lock file
sriramveeraghanta Sep 1, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/propel/src/tabs/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from "./tabs";
58 changes: 0 additions & 58 deletions packages/propel/src/tabs/list.tsx

This file was deleted.

66 changes: 66 additions & 0 deletions packages/propel/src/tabs/tabs.stories.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
import { Fragment } from "react";
import type { Meta, StoryObj } from "@storybook/react-vite";
import { Tabs } from "./tabs";

const meta: Meta<typeof Tabs> = {
title: "Components/Tabs",
component: Tabs,
parameters: {
layout: "centered",
},
};

export default meta;
type Story = StoryObj<typeof meta>;

export const Basic: Story = {
render: () => (
<div className="w-[400px]">
<Tabs defaultValue="account">
<Tabs.List>
<Tabs.Trigger value="account">Overview</Tabs.Trigger>
<Tabs.Trigger value="password">Settings</Tabs.Trigger>
<Tabs.Indicator />
</Tabs.List>
<Tabs.Content value="account" className="p-4">
Overview settings go here
</Tabs.Content>
<Tabs.Content value="password" className="p-4">
Settings settings go here
</Tabs.Content>
</Tabs>
</div>
),
};

export const Sizes: Story = {
render: () => {
const sizes = ["sm", "md", "lg"] as const;
const labels = {
sm: "Small",
md: "Medium",
lg: "Large",
};

return (
<div className="w-[400px]">
{sizes.map((size, index) => (
<Fragment key={size}>
{index > 0 && <div className="h-4" />}
<div className="text-lg">{labels[size]}</div>
<Tabs defaultValue="overview">
<Tabs.List>
<Tabs.Trigger value="overview" size={size}>
Overview
</Tabs.Trigger>
<Tabs.Trigger value="settings" size={size}>
Settings
</Tabs.Trigger>
</Tabs.List>
</Tabs>
</Fragment>
))}
</div>
);
},
};
167 changes: 87 additions & 80 deletions packages/propel/src/tabs/tabs.tsx
Original file line number Diff line number Diff line change
@@ -1,89 +1,96 @@
import React, { FC, useEffect, useState } from "react";
import { Tabs as BaseTabs } from "@base-ui-components/react/tabs";
import { useLocalStorage } from "@plane/hooks";
import * as React from "react";
import { Tabs as TabsPrimitive } from "@base-ui-components/react/tabs";
import { cn } from "../utils/classname";
import { TabList, TabListItem } from "./list";

export type TabContent = {
content: React.ReactNode;
type TabsCompound = React.ForwardRefExoticComponent<
React.ComponentProps<typeof TabsPrimitive.Root> & React.RefAttributes<React.ElementRef<typeof TabsPrimitive.Root>>
> & {
List: React.ForwardRefExoticComponent<
React.ComponentProps<typeof TabsPrimitive.List> & React.RefAttributes<React.ElementRef<typeof TabsPrimitive.List>>
>;
Trigger: React.ForwardRefExoticComponent<
React.ComponentProps<typeof TabsPrimitive.Tab> & { size?: "sm" | "md" | "lg" } & React.RefAttributes<
React.ElementRef<typeof TabsPrimitive.Tab>
>
>;
Content: React.ForwardRefExoticComponent<
React.ComponentProps<typeof TabsPrimitive.Panel> & React.RefAttributes<React.ElementRef<typeof TabsPrimitive.Panel>>
>;
Indicator: React.ForwardRefExoticComponent<React.ComponentProps<"div"> & React.RefAttributes<HTMLDivElement>>;
};

export type TabItem = TabListItem & TabContent;
const TabsRoot = React.forwardRef<
React.ElementRef<typeof TabsPrimitive.Root>,
React.ComponentProps<typeof TabsPrimitive.Root>
>(({ className, ...props }, ref) => (
<TabsPrimitive.Root data-slot="tabs" className={cn("flex flex-col w-full h-full", className)} {...props} ref={ref} />
));

type TTabsProps = {
tabs: TabItem[];
storageKey?: string;
actions?: React.ReactNode;
defaultTab?: string;
containerClassName?: string;
tabListContainerClassName?: string;
tabListClassName?: string;
tabClassName?: string;
tabPanelClassName?: string;
size?: "sm" | "md" | "lg";
storeInLocalStorage?: boolean;
};

export const Tabs: FC<TTabsProps> = (props: TTabsProps) => {
const {
tabs,
storageKey,
actions,
defaultTab = tabs[0]?.key,
containerClassName = "",
tabListContainerClassName = "",
tabListClassName = "",
tabClassName = "",
tabPanelClassName = "",
size = "md",
storeInLocalStorage = true,
} = props;

const { storedValue, setValue } = useLocalStorage(
storeInLocalStorage && storageKey ? `tab-${storageKey}` : `tab-${tabs[0]?.key}`,
defaultTab
);
const TabsList = React.forwardRef<
React.ElementRef<typeof TabsPrimitive.List>,
React.ComponentProps<typeof TabsPrimitive.List>
>(({ className, ...props }, ref) => (
<TabsPrimitive.List
data-slot="tabs-list"
className={cn(
"flex w-full min-w-fit items-center justify-between gap-1.5 rounded-md text-sm p-0.5 bg-custom-background-80/60 relative overflow-auto",
className
)}
{...props}
ref={ref}
/>
));

const [activeIndex, setActiveIndex] = useState(() => {
const initialTab = storedValue ?? defaultTab;
return tabs.findIndex((tab) => tab.key === initialTab);
});
const TabsTrigger = React.forwardRef<
React.ElementRef<typeof TabsPrimitive.Tab>,
React.ComponentProps<typeof TabsPrimitive.Tab> & { size?: "sm" | "md" | "lg" }
>(({ className, size = "md", ...props }, ref) => (
<TabsPrimitive.Tab
data-slot="tabs-trigger"
className={cn(
"flex items-center justify-center p-1 min-w-fit w-full font-medium text-custom-text-100 outline-none focus:outline-none cursor-pointer transition-all duration-200 ease-in-out rounded",
"data-[selected]:bg-custom-background-100 data-[selected]:text-custom-text-100 data-[selected]:shadow-sm",
"text-custom-text-400 hover:text-custom-text-300 hover:bg-custom-background-80/60",
"disabled:text-custom-text-400 disabled:cursor-not-allowed",
{
"text-xs": size === "sm",
"text-sm": size === "md",
"text-base": size === "lg",
},
className
)}
{...props}
ref={ref}
/>
));

useEffect(() => {
if (storeInLocalStorage && tabs[activeIndex]) {
setValue(tabs[activeIndex].key);
}
}, [activeIndex, setValue, storeInLocalStorage, tabs]);
const TabsContent = React.forwardRef<
React.ElementRef<typeof TabsPrimitive.Panel>,
React.ComponentProps<typeof TabsPrimitive.Panel>
>(({ className, ...props }, ref) => (
<TabsPrimitive.Panel
data-slot="tabs-content"
className={cn("relative outline-none", className)}
{...props}
ref={ref}
/>
));
const TabsIndicator = React.forwardRef<HTMLDivElement, React.ComponentProps<"div">>(({ className, ...props }, ref) => (
<div
className={cn(
"absolute left-0 top-[50%] z-[-1] h-6 w-[var(--active-tab-width)] translate-x-[var(--active-tab-left)] -translate-y-[50%] rounded-sm bg-custom-background-100 shadow-sm transition-[width,transform] duration-200 ease-in-out",
className
)}
{...props}
ref={ref}
/>
));

const handleTabChange = (index: number) => {
setActiveIndex(index);
if (!tabs[index].disabled) {
tabs[index].onClick?.();
}
};
export const Tabs = Object.assign(TabsRoot, {
List: TabsList,
Trigger: TabsTrigger,
Content: TabsContent,
Indicator: TabsIndicator,
}) satisfies TabsCompound;

return (
<BaseTabs.Root
value={activeIndex}
onValueChange={handleTabChange}
className={cn("flex flex-col w-full h-full overflow-hidden", containerClassName)}
>
<div className={cn("flex w-full items-center gap-4", tabListContainerClassName)}>
<TabList
tabs={tabs}
tabListClassName={tabListClassName}
tabClassName={tabClassName}
size={size}
selectedTab={tabs[activeIndex]?.key}
/>
{actions && <div className="flex-grow">{actions}</div>}
</div>

{tabs.map((tab) => (
<BaseTabs.Panel key={tab.key} className={cn("relative h-full overflow-auto", tabPanelClassName)}>
{tab.content}
</BaseTabs.Panel>
))}
</BaseTabs.Root>
);
};
export { TabsList, TabsTrigger, TabsContent, TabsIndicator };
23 changes: 11 additions & 12 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading