-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[WEB-4734] feat: replace emoji picker with frimousse #7639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
bf1abf1
chore: replace emoji-picker-react with frimousse package
anmolsinghbhatia 0d719fd
chore: update emoji picker component, utilities, and types
anmolsinghbhatia 4289e75
chore: update emoji picker component instances
anmolsinghbhatia 13118b5
chore: code refactor
anmolsinghbhatia b846e9a
fix: lint and format
anmolsinghbhatia 1594cf5
fix: callout emoji picker
aaryan610 f76d420
preview sync
anmolsinghbhatia 05a027d
Merge branch 'preview' of github.com:makeplane/plane into feat-replac…
anmolsinghbhatia aceb8cb
Merge branch 'preview' of github.com:makeplane/plane into feat-replac…
anmolsinghbhatia eb8605b
Merge branch 'preview' of github.com:makeplane/plane into feat-replac…
anmolsinghbhatia 058c847
dev: emoji picker added to propel package
anmolsinghbhatia 5ff7fb1
chore: popover component positionerClassName prop added
anmolsinghbhatia 1cdf355
chore: propel emoji picker implementation and code refactor
anmolsinghbhatia 85278d7
chore: code refactor
anmolsinghbhatia 6940f89
fix: preview sync merge conflict
anmolsinghbhatia c7b4bf1
fix: format issue
anmolsinghbhatia 9de98ce
chore: code refactor
anmolsinghbhatia a3f12be
chore: code refactor
anmolsinghbhatia 7507f51
chore: code refactor
anmolsinghbhatia 4b58580
chore: code refactor
anmolsinghbhatia 0c21aec
Merge branch 'preview' of github.com:makeplane/plane into feat-replac…
anmolsinghbhatia 360d633
chore: code refactor
anmolsinghbhatia dd95d94
chore: code refactor
anmolsinghbhatia 3de9612
Merge branch 'preview' of github.com:makeplane/plane into feat-replac…
anmolsinghbhatia d1de4ce
chore: revert pages level emoji picker changes while maintaining core…
anmolsinghbhatia 31f0f50
chore: code refactor
anmolsinghbhatia d2060f5
fix: preview sync merge conflict
anmolsinghbhatia d581d6c
fix: build error
anmolsinghbhatia 77d1c51
Merge branch 'preview' of github.com:makeplane/plane into feat-replac…
anmolsinghbhatia 6b7d51a
chore: code refactor
anmolsinghbhatia b79b92b
🔀 fix: preview sync merge conflict
anmolsinghbhatia 5c8b021
chore: code refactor
anmolsinghbhatia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
apps/web/core/components/analytics/overview/active-project-item.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
packages/propel/src/emoji-icon-picker/emoji-picker.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import { useState } from "react"; | ||
| import type { Meta, StoryObj } from "@storybook/react-vite"; | ||
| import { EmojiPicker } from "./emoji-picker"; | ||
| import { EmojiIconPickerTypes } from "./helper"; | ||
|
|
||
| const meta: Meta<typeof EmojiPicker> = { | ||
| title: "EmojiPicker", | ||
| component: EmojiPicker, | ||
| parameters: { | ||
| layout: "centered", | ||
| }, | ||
| tags: ["autodocs"], | ||
| }; | ||
|
|
||
| export default meta; | ||
| type Story = StoryObj<typeof EmojiPicker>; | ||
|
|
||
| const EmojiPickerWithState = (args: React.ComponentProps<typeof EmojiPicker>) => { | ||
| const [isOpen, setIsOpen] = useState(false); | ||
| const [selectedValue, setSelectedValue] = useState<any>(null); | ||
|
|
||
| return ( | ||
| <div className="space-y-4"> | ||
| <EmojiPicker | ||
| {...args} | ||
| isOpen={isOpen} | ||
| handleToggle={setIsOpen} | ||
| onChange={(value) => { | ||
| setSelectedValue(value); | ||
| console.log("Selected:", value); | ||
| }} | ||
| /> | ||
| {selectedValue && <div className="text-sm text-gray-600">Selected: {JSON.stringify(selectedValue, null, 2)}</div>} | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export const Default: Story = { | ||
| render: (args: React.ComponentProps<typeof EmojiPicker>) => <EmojiPickerWithState {...args} />, | ||
| args: { | ||
| label: "😊 Pick an emoji or icon", | ||
| defaultOpen: EmojiIconPickerTypes.EMOJI, | ||
| closeOnSelect: true, | ||
| searchPlaceholder: "Search emojis...", | ||
| iconType: "lucide", | ||
| }, | ||
| }; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.