-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[WEB-4689]chore: added accordion to propel #7641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5cc257a
chore: added accordion to propel
vamsikrishnamathala 0fe7536
fix: lint errors
vamsikrishnamathala 82e7936
fix: updated export path
vamsikrishnamathala 39207f1
fix: lint errors
vamsikrishnamathala d1b9a4f
chore: made accordion into compound component
vamsikrishnamathala 505cff7
fix: coderabbit suggestions
vamsikrishnamathala ebcf87d
Merge branch 'preview' of github.com:makeplane/plane into chore-accor…
vamsikrishnamathala File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| import { Accordion as BaseAccordion } from "@base-ui-components/react"; | ||
| import { PlusIcon } from "lucide-react"; | ||
| import * as React from "react"; | ||
|
|
||
| interface AccordionRootProps { | ||
| defaultValue?: string[]; | ||
| allowMultiple?: boolean; | ||
| className?: string; | ||
| children: React.ReactNode; | ||
| } | ||
|
|
||
| interface AccordionItemProps { | ||
| value: string; | ||
| disabled?: boolean; | ||
| className?: string; | ||
| children: React.ReactNode; | ||
| } | ||
|
|
||
| interface AccordionTriggerProps { | ||
| className?: string; | ||
| icon?: React.ReactNode; | ||
| children: React.ReactNode; | ||
| asChild?: boolean; | ||
| iconClassName?: string; | ||
| } | ||
|
|
||
| interface AccordionContentProps { | ||
| className?: string; | ||
| contentWrapperClassName?: string; | ||
| children: React.ReactNode; | ||
| } | ||
|
|
||
| const AccordionRoot: React.FC<AccordionRootProps> = ({ | ||
| defaultValue = [], | ||
| allowMultiple = false, | ||
| className = "", | ||
| children, | ||
| }) => ( | ||
| <BaseAccordion.Root defaultValue={defaultValue} openMultiple={allowMultiple} className={`text-base ${className}`}> | ||
| {children} | ||
| </BaseAccordion.Root> | ||
| ); | ||
|
|
||
| const AccordionItem: React.FC<AccordionItemProps> = ({ value, disabled, className = "", children }) => ( | ||
| <BaseAccordion.Item value={value} disabled={disabled} className={`relative ${className}`}> | ||
| {children} | ||
| </BaseAccordion.Item> | ||
| ); | ||
|
|
||
| const AccordionTrigger: React.FC<AccordionTriggerProps> = ({ | ||
| className = "", | ||
| icon = <PlusIcon aria-hidden="true" className="transition-all ease-out group-data-[panel-open]:rotate-45" />, | ||
| iconClassName = "", | ||
| children, | ||
| asChild = false, | ||
| }) => ( | ||
| <BaseAccordion.Header> | ||
| {asChild ? ( | ||
| <BaseAccordion.Trigger className={`w-full py-2 ${className}`}>{children}</BaseAccordion.Trigger> | ||
| ) : ( | ||
| <BaseAccordion.Trigger className={`flex w-full items-center justify-between gap-2 py-2 ${className}`}> | ||
| {children} | ||
| <span aria-hidden="true" className={`flex-shrink-0 ${iconClassName}`}> | ||
| {icon} | ||
| </span> | ||
| </BaseAccordion.Trigger> | ||
| )} | ||
| </BaseAccordion.Header> | ||
| ); | ||
|
|
||
| const AccordionContent: React.FC<AccordionContentProps> = ({ | ||
| className = "", | ||
| contentWrapperClassName = "", | ||
| children, | ||
| }) => ( | ||
| <BaseAccordion.Panel | ||
| className={`h-[var(--accordion-panel-height)] overflow-hidden transition-[height] ease-out data-[ending-style]:h-0 data-[starting-style]:h-0 ${className}`} | ||
| > | ||
| <div className={`py-2 ${contentWrapperClassName}`}>{children}</div> | ||
| </BaseAccordion.Panel> | ||
| ); | ||
|
|
||
| export const Accordion = { | ||
| Root: AccordionRoot, | ||
| Item: AccordionItem, | ||
| Trigger: AccordionTrigger, | ||
| Content: AccordionContent, | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export * from "./accordion"; | ||
vamsikrishnamathala marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.