Skip to content

[WEB-4196]fix: toast message for sub work item quick actions #7688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pushya22 merged 2 commits into from
Sep 2, 2025
Merged

[WEB-4196]fix: toast message for sub work item quick actions #7688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57b85bd
fix: toast message for sub work item quick actions
vamsikrishnamathala Sep 1, 2025
1b22557
chore: updated translation files
vamsikrishnamathala Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions apps/web/core/components/issues/issue-detail-widgets/sub-issues/helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ export const useSubIssueOperations = (issueServiceType: TIssueServiceType): TSub
type: TOAST_TYPE.SUCCESS,
title: t("common.link_copied"),
message: t("entity.link_copied_to_clipboard", {
entity: t("epic.label", { count: 1 }),
entity:
issueServiceType === EIssueServiceType.ISSUES
? t("common.sub_work_items", { count: 1 })
: t("issue.label", { count: 1 }),
}),
});
});
Expand Down Expand Up @@ -77,7 +80,7 @@ export const useSubIssueOperations = (issueServiceType: TIssueServiceType): TSub
entity:
issueServiceType === EIssueServiceType.ISSUES
? t("common.sub_work_items")
: t("issue.label", { count: 2 }),
: t("issue.label", { count: issueIds.length }),
}),
});
} catch {
Expand All @@ -88,7 +91,7 @@ export const useSubIssueOperations = (issueServiceType: TIssueServiceType): TSub
entity:
issueServiceType === EIssueServiceType.ISSUES
? t("common.sub_work_items")
: t("issue.label", { count: 2 }),
: t("issue.label", { count: issueIds.length }),
}),
});
}
Expand Down Expand Up @@ -169,7 +172,12 @@ export const useSubIssueOperations = (issueServiceType: TIssueServiceType): TSub
setToast({
type: TOAST_TYPE.SUCCESS,
title: t("toast.success"),
message: t("sub_work_item.remove.success"),
message: t("entity.remove.success", {
entity:
issueServiceType === EIssueServiceType.ISSUES
? t("common.sub_work_items")
: t("issue.label", { count: 1 }),
}),
});
captureSuccess({
eventName: WORK_ITEM_TRACKER_EVENTS.sub_issue.remove,
Expand All @@ -185,7 +193,12 @@ export const useSubIssueOperations = (issueServiceType: TIssueServiceType): TSub
setToast({
type: TOAST_TYPE.ERROR,
title: t("toast.error"),
message: t("sub_work_item.remove.error"),
message: t("entity.remove.failed", {
entity:
issueServiceType === EIssueServiceType.ISSUES
? t("common.sub_work_items")
: t("issue.label", { count: 1 }),
}),
});
}
},
Expand All @@ -208,7 +221,12 @@ export const useSubIssueOperations = (issueServiceType: TIssueServiceType): TSub
setToast({
type: TOAST_TYPE.ERROR,
title: t("toast.error"),
message: t("issue.delete.error"),
message: t("entity.delete.failed", {
entity:
issueServiceType === EIssueServiceType.ISSUES
? t("common.sub_work_items")
: t("issue.label", { count: 1 }),
}),
});
}
},
Expand Down
4 changes: 4 additions & 0 deletions packages/i18n/src/locales/cs/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,10 @@
"add": {
"success": "{entity} úspěšně přidána",
"failed": "Chyba při přidávání {entity}"
},
"remove": {
"success": "{entity} úspěšně odebrána",
"failed": "Chyba při odebírání {entity}"
}
},
"epic": {
Expand Down
4 changes: 4 additions & 0 deletions packages/i18n/src/locales/de/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,10 @@
"add": {
"success": "{entity} erfolgreich hinzugefügt",
"failed": "Fehler beim Hinzufügen von {entity}"
},
"remove": {
"success": "{entity} erfolgreich entfernt",
"failed": "Fehler beim Entfernen von {entity}"
}
},
"epic": {
Expand Down
4 changes: 4 additions & 0 deletions packages/i18n/src/locales/en/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,6 +759,10 @@
"add": {
"success": "{entity} added successfully",
"failed": "Error adding {entity}"
},
"remove": {
"success": "{entity} removed successfully",
"failed": "Error removing {entity}"
}
},
"epic": {
Expand Down
4 changes: 4 additions & 0 deletions packages/i18n/src/locales/es/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -919,6 +919,10 @@
"add": {
"success": "{entity} agregado correctamente",
"failed": "Error al agregar {entity}"
},
"remove": {
"success": "{entity} eliminado correctamente",
"failed": "Error al eliminar {entity}"
}
},
"epic": {
Expand Down
4 changes: 4 additions & 0 deletions packages/i18n/src/locales/fr/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -917,6 +917,10 @@
"add": {
"success": "{entity} ajouté avec succès",
"failed": "Erreur lors de l'ajout de {entity}"
},
"remove": {
"success": "{entity} supprimé avec succès",
"failed": "Erreur lors de la suppression de {entity}"
}
},
"epic": {
Expand Down
4 changes: 4 additions & 0 deletions packages/i18n/src/locales/id/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,10 @@
"add": {
"success": "{entity} berhasil ditambahkan",
"failed": "Terjadi kesalahan saat menambahkan {entity}"
},
"remove": {
"success": "{entity} berhasil dihapus",
"failed": "Terjadi kesalahan saat menghapus {entity}"
}
},
"epic": {
Expand Down
4 changes: 4 additions & 0 deletions packages/i18n/src/locales/it/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,6 +915,10 @@
"add": {
"success": "{entity} aggiunto con successo",
"failed": "Errore nell'aggiunta di {entity}"
},
"remove": {
"success": "{entity} rimosso con successo",
"failed": "Errore nella rimozione di {entity}"
}
},
"epic": {
Expand Down
4 changes: 4 additions & 0 deletions packages/i18n/src/locales/ja/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -917,6 +917,10 @@
"add": {
"success": "{entity}を追加しました",
"failed": "{entity}の追加中にエラーが発生しました"
},
"remove": {
"success": "{entity}を削除しました",
"failed": "{entity}の削除中にエラーが発生しました"
}
},
"epic": {
Expand Down
4 changes: 4 additions & 0 deletions packages/i18n/src/locales/ko/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,6 +918,10 @@
"add": {
"success": "{entity}가 성공적으로 추가되었습니다",
"failed": "{entity} 추가 중 오류 발생"
},
"remove": {
"success": "{entity}가 성공적으로 제거되었습니다",
"failed": "{entity} 제거 중 오류 발생"
}
},
"epic": {
Expand Down
4 changes: 4 additions & 0 deletions packages/i18n/src/locales/pl/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,6 +918,10 @@
"add": {
"success": "{entity} dodano pomyślnie",
"failed": "Błąd podczas dodawania {entity}"
},
"remove": {
"success": "{entity} usunięto pomyślnie",
"failed": "Błąd podczas usuwania {entity}"
}
},
"epic": {
Expand Down
4 changes: 4 additions & 0 deletions packages/i18n/src/locales/pt-BR/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,6 +918,10 @@
"add": {
"success": "{entity} adicionado com sucesso",
"failed": "Erro ao adicionar {entity}"
},
"remove": {
"success": "{entity} removido com sucesso",
"failed": "Erro ao remover {entity}"
}
Comment on lines +922 to 925
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify coverage across locales and placeholders

Ensure every locale defines entity.remove.success/failed and both include “{entity}”.

🏁 Script executed:

#!/bin/bash
set -euo pipefail
root="packages/i18n/src/locales"
missing=0

# Validate JSON and check keys/placeholders
fd translations.json "$root" -t f | while read -r f; do
  if ! jq -e 'has("entity") and .entity|has("remove") and .entity.remove|has("success") and .entity.remove|has("failed")' "$f" >/dev/null; then
    echo "MISSING keys: $f"
    missing=$((missing+1))
    continue
  fi
  for k in success failed; do
    val=$(jq -r ".entity.remove.$k" "$f")
    if [[ "$val" != *"{entity}"* ]]; then
      echo "PLACEHOLDER missing in $k: $f -> $val"
      missing=$((missing+1))
    fi
  done
done

if [[ $missing -eq 0 ]]; then
  echo "All locales OK: entity.remove.success/failed present with {entity}."
else
  echo "Found $missing issues."
  exit 1
fi

Length of output: 8797

Add missing entity.remove translations across locales
The following locale files lack entity.remove.success/failed entries with the {entity} placeholder:

  • packages/i18n/src/locales/cs/translations.json
  • packages/i18n/src/locales/de/translations.json
  • packages/i18n/src/locales/en/translations.json
  • packages/i18n/src/locales/es/translations.json
  • packages/i18n/src/locales/fr/translations.json
  • packages/i18n/src/locales/id/translations.json
  • packages/i18n/src/locales/it/translations.json
  • packages/i18n/src/locales/ja/translations.json
  • packages/i18n/src/locales/ko/translations.json
  • packages/i18n/src/locales/pl/translations.json
  • packages/i18n/src/locales/pt-BR/translations.json
  • packages/i18n/src/locales/ro/translations.json
  • packages/i18n/src/locales/ru/translations.json
  • packages/i18n/src/locales/sk/translations.json
  • packages/i18n/src/locales/tr-TR/translations.json
  • packages/i18n/src/locales/ua/translations.json
  • packages/i18n/src/locales/vi-VN/translations.json
  • packages/i18n/src/locales/zh-CN/translations.json
  • packages/i18n/src/locales/zh-TW/translations.json

In each, add under the entity key:

"remove": {
  "success": "{entity} removido com sucesso",
  "failed": "Erro ao remover {entity}"
}

(adjust wording per locale, keeping the {entity} placeholder in both messages)

🤖 Prompt for AI Agents 
In packages/i18n/src/locales/pt-BR/translations.json around lines 922 to 925,
the entity.remove translations are present for pt-BR but reviewer notes many
other locale files are missing entity.remove.success and entity.remove.failed
entries; for each listed locale file (cs, de, en, es, fr, id, it, ja, ko, pl,
pt-BR, ro, ru, sk, tr-TR, ua, vi-VN, zh-CN, zh-TW) add an "remove" object under
the "entity" key with two entries: a success message and a failed message that
both include the "{entity}" placeholder; translate the wording appropriately per
locale while preserving the {entity} token exactly and place the entries in the
same structure/location as other entity messages to keep consistency.

},
"epic": {
Expand Down
4 changes: 4 additions & 0 deletions packages/i18n/src/locales/ro/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,10 @@
"add": {
"success": "{entity} a fost adăugată cu succes",
"failed": "Eroare la adăugarea {entity}"
},
"remove": {
"success": "{entity} a fost eliminată cu succes",
"failed": "Eroare la eliminarea {entity}"
}
},
"epic": {
Expand Down
4 changes: 4 additions & 0 deletions packages/i18n/src/locales/ru/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,6 +918,10 @@
"add": {
"success": "{entity} успешно добавлен",
"failed": "Ошибка добавления {entity}"
},
"remove": {
"success": "{entity} успешно удален",
"failed": "Ошибка удаления {entity}"
}
},
"epic": {
Expand Down
4 changes: 4 additions & 0 deletions packages/i18n/src/locales/sk/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,6 +918,10 @@
"add": {
"success": "{entity} bola úspešne pridaná",
"failed": "Chyba pri pridávaní {entity}"
},
"remove": {
"success": "{entity} bola úspešne odstránená",
"failed": "Chyba pri odstrávaní {entity}"
}
},
"epic": {
Expand Down
4 changes: 4 additions & 0 deletions packages/i18n/src/locales/tr-TR/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,6 +920,10 @@
"add": {
"success": "{entity} başarıyla eklendi",
"failed": "{entity} eklenirken hata oluştu"
},
"remove": {
"success": "{entity} başarıyla kaldırıldı",
"failed": "{entity} kaldırılırken hata oluştu"
}
},
"epic": {
Expand Down
4 changes: 4 additions & 0 deletions packages/i18n/src/locales/ua/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,6 +918,10 @@
"add": {
"success": "{entity} успішно додано",
"failed": "Помилка під час додавання {entity}"
},
"remove": {
"success": "{entity} успішно видалено",
"failed": "Помилка під час видалення {entity}"
}
},
"epic": {
Expand Down
4 changes: 4 additions & 0 deletions packages/i18n/src/locales/vi-VN/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -917,6 +917,10 @@
"add": {
"success": "Đã thêm {entity} thành công",
"failed": "Đã xảy ra lỗi khi thêm {entity}"
},
"remove": {
"success": "Đã xóa {entity} thành công",
"failed": "Đã xảy ra lỗi khi xóa {entity}"
}
},
"epic": {
Expand Down
4 changes: 4 additions & 0 deletions packages/i18n/src/locales/zh-CN/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -917,6 +917,10 @@
"add": {
"success": "{entity}添加成功",
"failed": "添加{entity}时出错"
},
"remove": {
"success": "{entity}删除成功",
"failed": "删除{entity}时出错"
}
Comment on lines +921 to 924
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix mistranslation: use 移除 for “remove”, not 删除

“remove” ≠ “delete”. Elsewhere you use “移除” for remove (e.g., 子工作项移除成功). Update both keys to avoid user-facing confusion.

-      "success": "{entity}删除成功",
-      "failed": "删除{entity}时出错"
+      "success": "{entity}移除成功",
+      "failed": "移除{entity}时出错"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"remove": {
"success": "{entity}删除成功",
"failed": "删除{entity}时出错"
}
"remove": {
"success": "{entity}移除成功",
"failed": "移除{entity}时出错"
}
🤖 Prompt for AI Agents 
In packages/i18n/src/locales/zh-CN/translations.json around lines 921–924, the
translations use 删除 for the "remove" key which conflicts with other usages that
use 移除; change the values to use 移除 (e.g., "success": "{entity}移除成功", "failed":
"移除{entity}时出错") and ensure both keys are updated so the wording matches other
locales/entries that use 移除 for remove.

},
"epic": {
Expand Down
4 changes: 4 additions & 0 deletions packages/i18n/src/locales/zh-TW/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,6 +918,10 @@
"add": {
"success": "{entity} 新增成功",
"failed": "新增 {entity} 時發生錯誤"
},
"remove": {
"success": "{entity} 刪除成功",
"failed": "刪除 {entity} 時發生錯誤"
}
},
"epic": {
Expand Down
Loading