Skip to content

[WEB-4837] feat: adding more packages to catalog #7693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sriramveeraghanta merged 4 commits into from
Sep 2, 2025
Merged

[WEB-4837] feat: adding more packages to catalog #7693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5fbc859
feat: adding more packages to catalog
sriramveeraghanta Sep 1, 2025
af185a6
fix: merge conflicts from preview
sriramveeraghanta Sep 2, 2025
67d7a0c
fix: lock file
sriramveeraghanta Sep 2, 2025
f43e71f
fix: sharp pacakge catalog
sriramveeraghanta Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions apps/admin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,26 +26,26 @@
"@plane/ui": "workspace:*",
"@plane/utils": "workspace:*",
"autoprefixer": "10.4.14",
"axios": "1.11.0",
"lodash": "^4.17.21",
"lucide-react": "^0.469.0",
"mobx": "^6.12.0",
"mobx-react": "^9.1.1",
"next": "14.2.32",
"axios": "catalog:",
"lodash": "catalog:",
"lucide-react": "catalog:",
"mobx": "catalog:",
"mobx-react": "catalog:",
"next": "catalog:",
"next-themes": "^0.2.1",
"postcss": "^8.4.49",
"react": "catalog:",
"react-dom": "catalog:",
"react-hook-form": "7.51.5",
"sharp": "^0.33.5",
"swr": "^2.2.4",
"uuid": "^9.0.1"
"sharp": "catalog:",
"swr": "catalog:",
"uuid": "catalog:"
},
"devDependencies": {
"@plane/eslint-config": "workspace:*",
"@plane/tailwind-config": "workspace:*",
"@plane/typescript-config": "workspace:*",
"@types/lodash": "4.17.20",
"@types/lodash": "catalog:",
"@types/node": "18.16.1",
"@types/react": "catalog:",
"@types/react-dom": "catalog:",
Expand Down
6 changes: 3 additions & 3 deletions apps/live/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,19 @@
"@plane/types": "workspace:*",
"@tiptap/core": "^2.22.3",
"@tiptap/html": "^2.22.3",
"axios": "1.11.0",
"axios": "catalog:",
"compression": "1.8.1",
"cors": "^2.8.5",
"dotenv": "^16.4.5",
"express": "^4.21.2",
"express-ws": "^5.0.2",
"helmet": "^7.1.0",
"ioredis": "^5.4.1",
"lodash": "^4.17.21",
"lodash": "catalog:",
"morgan": "1.10.1",
"pino-http": "^10.3.0",
"pino-pretty": "^11.2.2",
"uuid": "^10.0.0",
"uuid": "catalog:",
"y-prosemirror": "^1.2.15",
"y-protocols": "^1.0.6",
"yjs": "^13.6.20"
Expand Down
22 changes: 11 additions & 11 deletions apps/space/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,35 +28,35 @@
"@plane/ui": "workspace:*",
"@plane/utils": "workspace:*",
"@popperjs/core": "^2.11.8",
"axios": "1.11.0",
"axios": "catalog:",
"clsx": "^2.0.0",
"date-fns": "^4.1.0",
"dompurify": "^3.0.11",
"dotenv": "^16.3.1",
"lodash": "^4.17.21",
"lodash": "catalog:",
"lowlight": "^2.9.0",
"lucide-react": "^0.469.0",
"mobx": "^6.10.0",
"mobx-react": "^9.1.1",
"mobx-utils": "^6.0.8",
"next": "14.2.32",
"lucide-react": "catalog:",
"mobx": "catalog:",
"mobx-react": "catalog:",
"mobx-utils": "catalog:",
"next": "catalog:",
"next-themes": "^0.2.1",
"nprogress": "^0.2.0",
"react": "catalog:",
"react-dom": "catalog:",
"react-dropzone": "^14.2.3",
"react-hook-form": "7.51.5",
"react-popper": "^2.3.0",
"sharp": "^0.33.5",
"swr": "^2.2.2",
"sharp": "catalog:",
"swr": "catalog:",
"tailwind-merge": "^2.0.0",
"uuid": "^9.0.0"
"uuid": "catalog:"
},
"devDependencies": {
"@plane/eslint-config": "workspace:*",
"@plane/tailwind-config": "workspace:*",
"@plane/typescript-config": "workspace:*",
"@types/lodash": "4.17.20",
"@types/lodash": "catalog:",
"@types/node": "18.14.1",
"@types/nprogress": "^0.2.0",
"@types/react": "catalog:",
Expand Down
22 changes: 11 additions & 11 deletions apps/web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"@popperjs/core": "^2.11.8",
"@react-pdf/renderer": "^3.4.5",
"@tanstack/react-table": "^8.21.3",
"axios": "1.11.0",
"axios": "catalog:",
"clsx": "^2.0.0",
"cmdk": "^1.0.0",
"comlink": "^4.4.1",
Expand All @@ -42,12 +42,12 @@
"emoji-picker-react": "^4.5.16",
"export-to-csv": "^1.4.0",
"isomorphic-dompurify": "^2.12.0",
"lodash": "^4.17.21",
"lucide-react": "^0.469.0",
"mobx": "^6.10.0",
"mobx-react": "^9.1.1",
"mobx-utils": "^6.0.8",
"next": "14.2.32",
"lodash": "catalog:",
"lucide-react": "catalog:",
"mobx": "catalog:",
"mobx-react": "catalog:",
"mobx-utils": "catalog:",
"next": "catalog:",
"next-themes": "^0.2.1",
"posthog-js": "^1.131.3",
"react": "catalog:",
Expand All @@ -61,18 +61,18 @@
"react-pdf-html": "^2.1.2",
"react-popper": "^2.3.0",
"recharts": "^2.12.7",
"sharp": "^0.33.5",
"sharp": "catalog:",
"smooth-scroll-into-view-if-needed": "^2.0.2",
"swr": "^2.1.3",
"swr": "catalog:",
"tailwind-merge": "^2.0.0",
"use-font-face-observer": "^1.2.2",
"uuid": "^9.0.0"
"uuid": "catalog:"
},
"devDependencies": {
"@plane/eslint-config": "workspace:*",
"@plane/tailwind-config": "workspace:*",
"@plane/typescript-config": "workspace:*",
"@types/lodash": "4.17.20",
"@types/lodash": "catalog:",
"@types/node": "18.16.1",
"@types/react": "catalog:",
"@types/react-color": "^3.0.6",
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@
"prosemirror-view": "1.40.0",
"@types/express": "4.17.23",
"typescript": "catalog:",
"sharp": "0.33.5"
"sharp": "catalog:"
}
},
"packageManager": "pnpm@10.12.1",
"engines": {
"node": ">=22.18.0"
}
}
}
4 changes: 2 additions & 2 deletions packages/editor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,11 @@
"jsx-dom-cjs": "^8.0.3",
"linkifyjs": "^4.3.2",
"lowlight": "^3.0.0",
"lucide-react": "^0.469.0",
"lucide-react": "catalog:",
"prosemirror-codemark": "^0.4.2",
"tippy.js": "^6.3.7",
"tiptap-markdown": "^0.8.10",
"uuid": "^10.0.0",
"uuid": "catalog:",
"y-indexeddb": "^9.0.12",
"y-prosemirror": "^1.2.15",
"y-protocols": "^1.0.6",
Expand Down
8 changes: 4 additions & 4 deletions packages/i18n/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@
"dependencies": {
"@plane/utils": "workspace:*",
"intl-messageformat": "^10.7.11",
"mobx": "^6.13.5",
"mobx-react": "^9.1.0",
"lodash": "^4.17.21"
"mobx": "catalog:",
"mobx-react": "catalog:",
"lodash": "catalog:"
},
"devDependencies": {
"@plane/eslint-config": "workspace:*",
"@plane/typescript-config": "workspace:*",
"@types/node": "^22.5.4",
"@types/lodash": "4.17.20",
"@types/lodash": "catalog:",
"@types/react": "catalog:",
"typescript": "catalog:"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/propel/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"cmdk": "^1.1.1",
"clsx": "^2.1.1",
"frimousse": "^0.3.0",
"lucide-react": "^0.469.0",
"lucide-react": "catalog:",
"react": "catalog:",
"react-dom": "catalog:",
Comment on lines +44 to 46
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Make React a peerDependency to avoid duplicate React in consumers

Libraries should not ship React as a prod dependency. Duplicate React breaks hooks and context. Move react/react-dom to peerDependencies (and keep types in devDependencies).

   "dependencies": {
@@
-    "lucide-react": "catalog:",
-    "react": "catalog:",
-    "react-dom": "catalog:",
+    "lucide-react": "catalog:",
     "recharts": "^2.15.1",
     "tailwind-merge": "^3.3.1",
     "use-font-face-observer": "^1.3.0"
   },
+  "peerDependencies": {
+    "react": "catalog:",
+    "react-dom": "catalog:"
+  },
   "devDependencies": {
@@
-    "@types/react": "catalog:",
-    "@types/react-dom": "catalog:",
+    "@types/react": "catalog:",
+    "@types/react-dom": "catalog:",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"lucide-react": "catalog:",
"react": "catalog:",
"react-dom": "catalog:",
"dependencies": {
"lucide-react": "catalog:",
"recharts": "^2.15.1",
"tailwind-merge": "^3.3.1",
"use-font-face-observer": "^1.3.0"
},
"peerDependencies": {
"react": "catalog:",
"react-dom": "catalog:"
},
"devDependencies": {
"@types/react": "catalog:",
"@types/react-dom": "catalog:",
// …other devDependencies…
}
🤖 Prompt for AI Agents 
In packages/propel/package.json around lines 44-46, react and react-dom are
listed as production dependencies which can cause duplicate React in consuming
apps; remove the "react" and "react-dom" entries from dependencies and add them
to peerDependencies using the same version spec (i.e. "catalog:"), and keep or
add the corresponding type packages (e.g. @types/react, @types/react-dom) under
devDependencies so consumers provide React while types remain for local
development.

"recharts": "^2.15.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/services/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"dependencies": {
"@plane/constants": "workspace:*",
"@plane/types": "workspace:*",
"axios": "1.11.0"
"axios": "catalog:"
},
"devDependencies": {
"@plane/eslint-config": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion packages/shared-state/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist"
},
"dependencies": {
"mobx": "^6.13.5",
"mobx": "catalog:",
"zod": "^3.22.2"
},
"devDependencies": {
Expand Down
6 changes: 3 additions & 3 deletions packages/ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
"@radix-ui/react-scroll-area": "^1.2.3",
"clsx": "^2.0.0",
"emoji-picker-react": "^4.5.16",
"lodash": "^4.17.21",
"lucide-react": "^0.469.0",
"lodash": "catalog:",
"lucide-react": "catalog:",
"react-color": "^2.19.3",
"react-day-picker": "9.5.0",
"react-popper": "^2.3.0",
Expand All @@ -67,7 +67,7 @@
"@storybook/react": "^8.1.1",
"@storybook/react-webpack5": "^8.1.1",
"@storybook/test": "^8.1.1",
"@types/lodash": "4.17.20",
"@types/lodash": "catalog:",
"@types/node": "^20.5.2",
"@types/react": "catalog:",
"@types/react-color": "^3.0.9",
Expand Down
8 changes: 4 additions & 4 deletions packages/utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,17 @@
"clsx": "^2.1.1",
"date-fns": "^4.1.0",
"isomorphic-dompurify": "^2.16.0",
"lodash": "^4.17.21",
"lucide-react": "^0.469.0",
"lodash": "catalog:",
"lucide-react": "catalog:",
"react": "catalog:",
"tailwind-merge": "^2.5.5",
"tlds": "1.259.0",
"uuid": "^10.0.0"
"uuid": "catalog:"
},
"devDependencies": {
"@plane/eslint-config": "workspace:*",
"@plane/typescript-config": "workspace:*",
"@types/lodash": "4.17.20",
"@types/lodash": "catalog:",
"@types/node": "^22.5.4",
"@types/react": "catalog:",
"@types/uuid": "^9.0.8",
Expand Down
Loading
Loading