[WEB-4829] refactor: remove start us CTA from header#7695
[WEB-4829] refactor: remove start us CTA from header#7695prateekshourya29 wants to merge 1 commit intopreviewfrom
start us CTA from header#7695Conversation
prateekshourya29
requested review from
anmolsinghbhatia and
sriramveeraghanta
WalkthroughRemoved GitHub link/analytics from the workspace header, deleted related event constants, and removed the star_us_on_github translation key across all locales. No public API signatures changed. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Header as Workspace Header (Before)
participant Tracker as Event Tracker
participant GitHub as GitHub
User->>Header: Click GitHub icon
Header->>Tracker: capture(HEADER_GITHUB_ICON, GITHUB_REDIRECTED_TRACKER_EVENT)
Header->>GitHub: Redirect
sequenceDiagram
autonumber
actor User
participant Header as Workspace Header (After)
User->>Header: Interact with header
Note over Header: GitHub icon and tracking removed
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Pull Request Linked with Plane Work Items
Comment Automatically Generated by Plane |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
packages/i18n/src/locales/ua/translations.json (1)
606-611: Remove or reference orphaned translation keys
No code references were found forreordered_successfullyandreordering_failed; either implement their usage in the codebase or remove these entries from packages/i18n/src/locales/ua/translations.json.apps/web/app/(all)/[workspaceSlug]/(projects)/header.tsx (1)
33-41: Add an accessible name to the icon-only button on small screensOn small viewports the text is hidden, leaving an icon-only button with no accessible name. Add aria-label (and optional title).
Apply:
- <Button + <Button variant="neutral-primary" size="sm" onClick={() => toggleWidgetSettings(true)} - className="my-auto mb-0" + className="my-auto mb-0" + aria-label={t("home.manage_widgets")} + title={t("home.manage_widgets")} > <Shapes size={16} /> - <div className="hidden text-xs font-medium sm:hidden md:block">{t("home.manage_widgets")}</div> + <div className="hidden md:block text-xs font-medium">{t("home.manage_widgets")}</div> </Button>
🧹 Nitpick comments (1)
apps/web/app/(all)/[workspaceSlug]/(projects)/header.tsx (1)
40-40: Tailwind nit: remove redundant breakpoint utility"hidden sm:hidden md:block" redundantly hides twice; "hidden md:block" suffices.
Apply (already included above):
- <div className="hidden text-xs font-medium sm:hidden md:block">{t("home.manage_widgets")}</div> + <div className="hidden md:block text-xs font-medium">{t("home.manage_widgets")}</div>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (21)
apps/web/app/(all)/[workspaceSlug]/(projects)/header.tsx(1 hunks)packages/constants/src/event-tracker/core.ts(0 hunks)packages/i18n/src/locales/cs/translations.json(1 hunks)packages/i18n/src/locales/de/translations.json(1 hunks)packages/i18n/src/locales/en/translations.json(1 hunks)packages/i18n/src/locales/es/translations.json(1 hunks)packages/i18n/src/locales/fr/translations.json(1 hunks)packages/i18n/src/locales/id/translations.json(1 hunks)packages/i18n/src/locales/it/translations.json(1 hunks)packages/i18n/src/locales/ja/translations.json(1 hunks)packages/i18n/src/locales/ko/translations.json(1 hunks)packages/i18n/src/locales/pl/translations.json(1 hunks)packages/i18n/src/locales/pt-BR/translations.json(1 hunks)packages/i18n/src/locales/ro/translations.json(1 hunks)packages/i18n/src/locales/ru/translations.json(1 hunks)packages/i18n/src/locales/sk/translations.json(1 hunks)packages/i18n/src/locales/tr-TR/translations.json(1 hunks)packages/i18n/src/locales/ua/translations.json(1 hunks)packages/i18n/src/locales/vi-VN/translations.json(1 hunks)packages/i18n/src/locales/zh-CN/translations.json(1 hunks)packages/i18n/src/locales/zh-TW/translations.json(1 hunks)
💤 Files with no reviewable changes (1)
- packages/constants/src/event-tracker/core.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build and lint web apps
- GitHub Check: Analyze (javascript)
🔇 Additional comments (19)
packages/i18n/src/locales/ro/translations.json (1)
608-608: LGTM; no references to removed CTA keys (star_us_on_github,HEADER_GITHUB_ICON,GITHUB_REDIRECTED_TRACKER_EVENT) and all locale JSON files are valid.packages/i18n/src/locales/pt-BR/translations.json (1)
611-611: No stale references found and all translation JSON files are valid; approving changes.packages/i18n/src/locales/zh-CN/translations.json (1)
611-611: Cleanup complete and verified; LGTM.packages/i18n/src/locales/pl/translations.json (1)
610-611: Approve removal ofhome.star_us_on_githubVerified no lingering references and all locale JSON files remain valid.packages/i18n/src/locales/it/translations.json (1)
610-611: LGTM: Italian locale consistent with CTA removalNo functional impact; translation structure intact after removing home.star_us_on_github.
packages/i18n/src/locales/ko/translations.json (1)
610-611: LGTM: Korean locale consistent with CTA removalMatches the header refactor; no additional action needed.
packages/i18n/src/locales/ja/translations.json (1)
610-610: LGTM — removal reflected; title OK.“home.title” stays “ホーム”; consistent with the CTA deletion.
packages/i18n/src/locales/es/translations.json (1)
612-612: LGTM — Spanish title unchanged post-removal.“home.title” remains “Inicio”; aligns with dropping the CTA key.
packages/i18n/src/locales/de/translations.json (1)
608-609: Verify removal ofstar_us_on_githubusage
- Locale JSON valid and key absent in
packages/i18n/src/locales/*/translations.json.- Rerun search across code to rule out any remaining references:
rg -nP '\bhome\.star_us_on_github\b' -g '*.ts' -g '*.tsx' -g '*.js' -g '*.jsx'packages/i18n/src/locales/cs/translations.json (1)
608-609: Czech locale cleanup — LGTMKey removal is consistent; no structural issues observed.
packages/i18n/src/locales/id/translations.json (1)
608-609: Indonesian locale cleanup — LGTMConsistent with the PR objective; JSON remains well-formed.
packages/i18n/src/locales/ru/translations.json (1)
606-611: LGTM — no remaining references tostar_us_on_githuband JSON is valid.packages/i18n/src/locales/sk/translations.json (1)
606-611: Approve changes — no stale references; SK JSON valid.packages/i18n/src/locales/en/translations.json (1)
449-449: Approve: no stale references remain
Verified removal of star_us_on_github, HEADER_GITHUB_ICON, GITHUB_REDIRECTED_TRACKER_EVENT, and any header GitHub anchors; no occurrences found.packages/i18n/src/locales/vi-VN/translations.json (1)
610-610: LGTM: VI locale aligned with CTA removalHome title intact; no regressions noted.
packages/i18n/src/locales/fr/translations.json (1)
610-610: LGTM: FR locale aligned with CTA removalConsistent with the EN change; nothing else to fix.
packages/i18n/src/locales/tr-TR/translations.json (2)
611-611: LGTM: home.title present after CTA removal"home.title" is intact and aligns with its usage in header.tsx. No issues spotted in this locale file.
547-612:star_us_on_githubremoval verified Verified no references tostar_us_on_githubremain and alltranslations.jsonfiles include bothhome.titleandhome.manage_widgets.apps/web/app/(all)/[workspaceSlug]/(projects)/header.tsx (1)
3-12: Imports cleanup matches PR objectiveGitHub CTA-related imports are gone; header relies only on plane modules and existing components. Good.
2 participants
Description
This PR removes
Star us on GitHubCTA from header.Type of Change
Summary by CodeRabbit