[WIKI-647] chore: update image path #7734
Conversation
WalkthroughAsset base paths for multiple empty-state images were updated from /empty-state/pages/... to /empty-state/wiki/... in navigation pane empty states and pages list main content. No component APIs, logic, or layouts were changed. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull Request Overview
This pull request updates asset path references from /empty-state/pages/ to /empty-state/wiki/ across multiple components in the pages feature area, aligning with a directory restructuring effort.
- Updates asset path references in pages list main content component
- Updates asset path references in navigation pane empty state components
- Changes apply to both public/private/archived page states and navigation pane outline/assets states
Reviewed Changes
Copilot reviewed 3 out of 19 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/web/core/components/pages/pages-list-main-content.tsx | Updates multiple asset paths for page list empty states from pages to wiki directory |
| apps/web/ce/components/pages/navigation-pane/tab-panels/empty-states/outline.tsx | Updates outline tab empty state asset path from pages to wiki directory |
| apps/web/ce/components/pages/navigation-pane/tab-panels/empty-states/assets.tsx | Updates assets tab empty state asset path from pages to wiki directory |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Pull Request Linked with Plane Work Items Comment Automatically Generated by Plane |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
apps/web/core/components/pages/pages-list-main-content.tsx (2)
174-179: Alt text mismatch with heading; align terminology.Heading says “No matching pages” but alt is “No matching modules”. Align for consistency and accessibility.
- <Image - src={filters.searchQuery.length > 0 ? resolvedNameFilterImage : resolvedFiltersImage} - className="h-36 sm:h-48 w-36 sm:w-48 mx-auto" - alt="No matching modules" - /> + <Image + src={filters.searchQuery.length > 0 ? resolvedNameFilterImage : resolvedFiltersImage} + className="h-36 sm:h-48 w-36 sm:w-48 mx-auto" + alt="No matching pages" + />
58-69: LGTM—no stale “/empty-state/pages” references and all wiki assets exist under apps/web/public/empty-state/wiki. Optional: extract aWIKI_BASE = "/empty-state/wiki"constant to DRY up the repeated basePath.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
apps/web/public/empty-state/wiki/all-filters-dark.svgis excluded by!**/*.svgapps/web/public/empty-state/wiki/all-filters-light.svgis excluded by!**/*.svgapps/web/public/empty-state/wiki/name-filter-dark.svgis excluded by!**/*.svgapps/web/public/empty-state/wiki/name-filter-light.svgis excluded by!**/*.svg
📒 Files selected for processing (3)
apps/web/ce/components/pages/navigation-pane/tab-panels/empty-states/assets.tsx(1 hunks)apps/web/ce/components/pages/navigation-pane/tab-panels/empty-states/outline.tsx(1 hunks)apps/web/core/components/pages/pages-list-main-content.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build and lint web apps
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
apps/web/ce/components/pages/navigation-pane/tab-panels/empty-states/outline.tsx (1)
9-9: Outline asset path repointed; manual verification required
No matchingoutline.(png|svg|webp)file was found under the expected/empty-state/wiki/navigation-panepath—ensure the asset exists at/empty-state/wiki/navigation-pane/outline.{png|svg|webp}.
Description
This pull request updates several asset path references throughout the codebase to use the
/empty-state/wiki/directory instead of/empty-state/pages/.Type of Change
Screenshots and Media (if applicable)
Test Scenarios
References
Summary by CodeRabbit