Skip to content

[WIKI-647] chore: update image path #7734

Merged
pushya22 merged 2 commits intopreviewfrom
chore-image_path_update
Sep 8, 2025
Merged

[WIKI-647] chore: update image path #7734
pushya22 merged 2 commits intopreviewfrom
chore-image_path_update

Conversation

@iam-vipin
Copy link
Member

@iam-vipin iam-vipin commented Sep 8, 2025

Description

This pull request updates several asset path references throughout the codebase to use the /empty-state/wiki/ directory instead of /empty-state/pages/.

Type of Change

  • Code refactoring

Screenshots and Media (if applicable)

Test Scenarios

References

Summary by CodeRabbit

  • Bug Fixes
    • Fixed empty-state images that could fail to load or show outdated artwork in the Navigation Pane (Assets and Outline tabs).
    • Updated empty-state visuals across the Pages list (public, private, archived, and filter views) for improved consistency with the Wiki section.
    • Visual-only updates; no changes to functionality.

Copilot AI review requested due to automatic review settings September 8, 2025 09:57
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 8, 2025

Walkthrough

Asset base paths for multiple empty-state images were updated from /empty-state/pages/... to /empty-state/wiki/... in navigation pane empty states and pages list main content. No component APIs, logic, or layouts were changed.

Changes

Cohort / File(s) Summary
Navigation pane empty-state assets
apps/web/ce/components/pages/navigation-pane/tab-panels/empty-states/assets.tsx, apps/web/ce/components/pages/navigation-pane/tab-panels/empty-states/outline.tsx
Updated Image asset base paths from /empty-state/pages/navigation-pane/... to /empty-state/wiki/navigation-pane/....
Pages list empty-state assets
apps/web/core/components/pages/pages-list-main-content.tsx
Repointed multiple empty-state asset paths from /empty-state/pages/... to /empty-state/wiki/...; onboarding path unchanged.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • anmolsinghbhatia
  • sriramveeraghanta

Poem

I hop through paths, from pages to wiki lands,
Nudging image trails with careful paws and plans.
Empty states now point where new carrots lie,
A breadcrumb shift beneath a tidy sky.
Thump-thump—assets load, and so do I. 🥕✨

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore-image_path_update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates asset path references from /empty-state/pages/ to /empty-state/wiki/ across multiple components in the pages feature area, aligning with a directory restructuring effort.

  • Updates asset path references in pages list main content component
  • Updates asset path references in navigation pane empty state components
  • Changes apply to both public/private/archived page states and navigation pane outline/assets states

Reviewed Changes

Copilot reviewed 3 out of 19 changed files in this pull request and generated no comments.

File Description
apps/web/core/components/pages/pages-list-main-content.tsx Updates multiple asset paths for page list empty states from pages to wiki directory
apps/web/ce/components/pages/navigation-pane/tab-panels/empty-states/outline.tsx Updates outline tab empty state asset path from pages to wiki directory
apps/web/ce/components/pages/navigation-pane/tab-panels/empty-states/assets.tsx Updates assets tab empty state asset path from pages to wiki directory

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@makeplane
Copy link

makeplane bot commented Sep 8, 2025

Pull Request Linked with Plane Work Items

Comment Automatically Generated by Plane

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
apps/web/core/components/pages/pages-list-main-content.tsx (2)

174-179: Alt text mismatch with heading; align terminology.

Heading says “No matching pages” but alt is “No matching modules”. Align for consistency and accessibility.

-          <Image
-            src={filters.searchQuery.length > 0 ? resolvedNameFilterImage : resolvedFiltersImage}
-            className="h-36 sm:h-48 w-36 sm:w-48 mx-auto"
-            alt="No matching modules"
-          />
+          <Image
+            src={filters.searchQuery.length > 0 ? resolvedNameFilterImage : resolvedFiltersImage}
+            className="h-36 sm:h-48 w-36 sm:w-48 mx-auto"
+            alt="No matching pages"
+          />

58-69: LGTM—no stale “/empty-state/pages” references and all wiki assets exist under apps/web/public/empty-state/wiki. Optional: extract a WIKI_BASE = "/empty-state/wiki" constant to DRY up the repeated basePath.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20d139c and 085c95b.

⛔ Files ignored due to path filters (4)
  • apps/web/public/empty-state/wiki/all-filters-dark.svg is excluded by !**/*.svg
  • apps/web/public/empty-state/wiki/all-filters-light.svg is excluded by !**/*.svg
  • apps/web/public/empty-state/wiki/name-filter-dark.svg is excluded by !**/*.svg
  • apps/web/public/empty-state/wiki/name-filter-light.svg is excluded by !**/*.svg
📒 Files selected for processing (3)
  • apps/web/ce/components/pages/navigation-pane/tab-panels/empty-states/assets.tsx (1 hunks)
  • apps/web/ce/components/pages/navigation-pane/tab-panels/empty-states/outline.tsx (1 hunks)
  • apps/web/core/components/pages/pages-list-main-content.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Build and lint web apps
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
apps/web/ce/components/pages/navigation-pane/tab-panels/empty-states/outline.tsx (1)

9-9: Outline asset path repointed; manual verification required
No matching outline.(png|svg|webp) file was found under the expected /empty-state/wiki/navigation-pane path—ensure the asset exists at /empty-state/wiki/navigation-pane/outline.{png|svg|webp}.

@pushya22 pushya22 merged commit 0cb4976 into preview Sep 8, 2025
6 of 7 checks passed
@pushya22 pushya22 deleted the chore-image_path_update branch September 8, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants