Skip to content

[WEB-4890]fix: dropdown width#7778

Merged
pushya22 merged 1 commit intopreviewfrom
fix-dropdown_options
Sep 11, 2025
Merged

[WEB-4890]fix: dropdown width#7778
pushya22 merged 1 commit intopreviewfrom
fix-dropdown_options

Conversation

@vamsikrishnamathala
Copy link
Member

@vamsikrishnamathala vamsikrishnamathala commented Sep 11, 2025

Description

This PR cleans up CustomSelect components by removing unnecessary width styling props that were redundantly applied across multiple files. The dropdown components already handle proper sizing through their default implementation.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

Screenshots and Media (if applicable)

Test Scenarios

References

Summary by CodeRabbit

  • Style
    • Standardized select dropdown option widths across the app by removing forced full-width styling. Options now use default sizing for a cleaner, more consistent UI.
    • Affected areas include: GitHub user selection; Jira import/details; onboarding/create workspace and workspace details; workspace creation form; invitations and member role columns; project invitation modal; notification snooze time picker; and language/timezone preferences.

@vamsikrishnamathala vamsikrishnamathala self-assigned this Sep 11, 2025
@vamsikrishnamathala vamsikrishnamathala added the 🐛bug Something isn't working label Sep 11, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 11, 2025

Walkthrough

Removed optionsClassName="w-full" from CustomSelect across multiple UI components (integrations, onboarding/workspace forms, profile preferences, project/workspace invitations and member columns, and notification snooze modal). No logic, exports, or control-flow changes; only dropdown options styling affected.

Changes

Cohort / File(s) Summary of Changes
Integrations — GitHub/Jira
apps/web/core/components/integration/github/single-user-select.tsx, apps/web/core/components/integration/jira/give-details.tsx, apps/web/core/components/integration/jira/import-users.tsx
Removed optionsClassName="w-full" from CustomSelect instances.
Onboarding & Workspace Creation
apps/web/core/components/onboarding/create-workspace.tsx, apps/web/core/components/workspace/create-workspace-form.tsx
Removed optionsClassName="w-full" from organization_size CustomSelects.
Profile Preferences
apps/web/core/components/profile/preferences/language-timezone.tsx
Removed optionsClassName="w-full" from language CustomSelect.
Project Invitations & Settings
apps/web/core/components/project/send-project-invitation-modal.tsx, apps/web/core/components/project/settings/member-columns.tsx
Removed optionsClassName="w-full" from role/account type CustomSelects.
Workspace Invitations & Settings
apps/web/core/components/workspace/invite-modal/fields.tsx, apps/web/core/components/workspace/settings/member-columns.tsx, apps/web/core/components/workspace/settings/workspace-details.tsx
Removed optionsClassName="w-full" from role/account type/organization_size CustomSelects.
Notifications
apps/web/core/components/workspace-notifications/sidebar/notification-card/options/snooze/modal.tsx
Removed optionsClassName="w-full" from snooze time CustomSelect.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

ready_to_merge

Suggested reviewers

  • sriramveeraghanta
  • gakshita
  • anmolsinghbhatia

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title "[WEB-4890]fix: dropdown width" is concise and accurately summarizes the primary change—adjusting dropdown width behavior by removing explicit full-width styling from CustomSelects—so it relates directly to the changeset. It is short and readable for a teammate scanning history, though a minor formatting nit is that a space after the issue tag improves readability (e.g., "[WEB-4890] fix: dropdown width").
Description Check ✅ Passed The PR description includes a clear Description that explains the change (removing redundant width props from CustomSelect across multiple files) so the core template requirement is satisfied, but the Type of Change checkboxes, Test Scenarios, and Screenshots/Media sections are left blank and no references or verification steps are provided. These omissions reduce the usefulness of the description for reviewers and QA.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Poem

A nibble of CSS, a twitch of the nose,
I trimmed the dropdowns’ wardrobe of clothes.
No logic disturbed, just sleeker attire—
Options no longer stretch edge-to-wire.
Thump-thump goes QA, calm as can be,
Hop on, ship out—clean UI, whee! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8ee665f and 20fbf30.

📒 Files selected for processing (12)
  • apps/web/core/components/integration/github/single-user-select.tsx (0 hunks)
  • apps/web/core/components/integration/jira/give-details.tsx (0 hunks)
  • apps/web/core/components/integration/jira/import-users.tsx (0 hunks)
  • apps/web/core/components/onboarding/create-workspace.tsx (0 hunks)
  • apps/web/core/components/profile/preferences/language-timezone.tsx (0 hunks)
  • apps/web/core/components/project/send-project-invitation-modal.tsx (0 hunks)
  • apps/web/core/components/project/settings/member-columns.tsx (0 hunks)
  • apps/web/core/components/workspace-notifications/sidebar/notification-card/options/snooze/modal.tsx (0 hunks)
  • apps/web/core/components/workspace/create-workspace-form.tsx (0 hunks)
  • apps/web/core/components/workspace/invite-modal/fields.tsx (0 hunks)
  • apps/web/core/components/workspace/settings/member-columns.tsx (0 hunks)
  • apps/web/core/components/workspace/settings/workspace-details.tsx (0 hunks)
💤 Files with no reviewable changes (12)
  • apps/web/core/components/workspace/create-workspace-form.tsx
  • apps/web/core/components/workspace/settings/member-columns.tsx
  • apps/web/core/components/workspace/settings/workspace-details.tsx
  • apps/web/core/components/integration/github/single-user-select.tsx
  • apps/web/core/components/workspace/invite-modal/fields.tsx
  • apps/web/core/components/integration/jira/import-users.tsx
  • apps/web/core/components/onboarding/create-workspace.tsx
  • apps/web/core/components/profile/preferences/language-timezone.tsx
  • apps/web/core/components/project/send-project-invitation-modal.tsx
  • apps/web/core/components/project/settings/member-columns.tsx
  • apps/web/core/components/workspace-notifications/sidebar/notification-card/options/snooze/modal.tsx
  • apps/web/core/components/integration/jira/give-details.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build and lint web apps
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-dropdown_options

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vamsikrishnamathala vamsikrishnamathala changed the title fix: dropdown width [WEB-4890]fix: dropdown width Sep 11, 2025
@vamsikrishnamathala vamsikrishnamathala marked this pull request as ready for review September 11, 2025 13:02
@makeplane
Copy link

makeplane bot commented Sep 11, 2025

@pushya22 pushya22 merged commit 76a0b38 into preview Sep 11, 2025
7 of 9 checks passed
@pushya22 pushya22 deleted the fix-dropdown_options branch September 11, 2025 13:26
yarikoptic pushed a commit to yarikoptic/plane that referenced this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants