Skip to content

[WIKI-707] [WIKI-708] fix: editor floating ui modal #7909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pushya22 merged 3 commits into from
Oct 6, 2025
Merged

[WIKI-707] [WIKI-708] fix: editor floating ui modal #7909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f6d6ea
fix: block menu option behind issues over view
iam-vipin Oct 6, 2025
e09e1d3
fix: clicking mention closing modal
iam-vipin Oct 6, 2025
8b0b8f6
chore : move stop propagration to drop down modal
iam-vipin Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/editor/src/core/components/menus/block-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,10 @@ export const BlockMenu = (props: Props) => {
...floatingStyles,
animationFillMode: "forwards",
transitionTimingFunction: "cubic-bezier(0.16, 1, 0.3, 1)", // Expo ease out
zIndex: 100,
}}
className={cn(
"z-20 max-h-60 min-w-[7rem] overflow-y-scroll rounded-lg border border-custom-border-200 bg-custom-background-100 p-1.5 shadow-custom-shadow-rg",
"max-h-60 min-w-[7rem] overflow-y-scroll rounded-lg border border-custom-border-200 bg-custom-background-100 p-1.5 shadow-custom-shadow-rg",
"transition-all duration-300 transform origin-top-right",
isAnimatedIn ? "opacity-100 scale-100" : "opacity-0 scale-75"
)}
Expand Down
7 changes: 7 additions & 0 deletions packages/editor/src/core/extensions/mentions/mentions-list-dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,12 @@ export const MentionsListDropdown = forwardRef((props: MentionsListDropdownProps
<div
ref={commandListContainer}
className="z-10 max-h-[90vh] w-[14rem] overflow-y-auto rounded-md border-[0.5px] border-custom-border-300 bg-custom-background-100 px-2 py-2.5 shadow-custom-shadow-rg space-y-2"
onClick={(e) => {
e.stopPropagation();
}}
onMouseDown={(e) => {
e.stopPropagation();
}}
>
{isLoading ? (
<div className="text-center text-sm text-custom-text-400">Loading...</div>
Expand All @@ -138,6 +144,7 @@ export const MentionsListDropdown = forwardRef((props: MentionsListDropdownProps
)}
onClick={(e) => {
e.preventDefault();
e.stopPropagation();
selectItem(sectionIndex, itemIndex);
}}
onMouseEnter={() =>
Expand Down
1 change: 1 addition & 0 deletions packages/editor/src/core/extensions/mentions/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export const renderMentionsDropdown =
const element = component.element as HTMLElement;
element.style.position = "absolute";
element.style.zIndex = "100";

document.body.appendChild(element);
updateFloatingUIFloaterPosition(props.editor, element);
},
Expand Down
Loading