chore: use oxc tooling to speed up prettier#8117
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughAdds the Changes
Sequence Diagram(s)(omitted — changes are configuration and dependency updates, no control-flow changes to visualize) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull Request Overview
This PR integrates the oxc parser plugin to improve Prettier's performance across the monorepo. The changes add @prettier/plugin-oxc to all package configurations and update Prettier-related dependencies.
Key Changes:
- Added
@prettier/plugin-oxc@0.0.4as a devDependency across all packages and apps - Updated Prettier configuration files to use the oxc plugin
- Pinned Prettier version from
"latest"to"^3.6.2"for reproducible builds
Reviewed Changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Pinned Prettier version and added oxc plugin; removed tailwindcss plugin |
packages/*/package.json |
Added oxc plugin as devDependency to all packages |
packages/*/.prettierrc |
Added oxc plugin to Prettier configuration |
apps/*/package.json |
Added oxc plugin and migrated React Router dependencies to catalog references |
apps/*/.prettierrc |
Added oxc plugin to Prettier configuration |
apps/space/.prettierrc.json |
Removed in favor of .prettierrc |
apps/space/.prettierrc |
Created with oxc plugin configuration |
apps/space/package.json |
Removed unused emotion dependencies |
packages/editor/package.json |
Reordered dependencies alphabetically |
.prettierrc |
Created root configuration with oxc plugin |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fa58d3e to
4dd9524
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
20-20: Verify pinned version of oxc plugin.The oxc plugin is pinned to an exact pre-release version (
0.0.4) without semantic versioning flexibility (no^or~). Confirm whether this is intentional. Pre-release versions (0.x.x) typically receive breaking changes frequently, so exact pinning is reasonable, but this should be a deliberate choice aligned with team practices.If you intend to use a pre-release version with stricter pinning, this is acceptable as a security measure. However, document the rationale if this deviates from the monorepo's standard versioning strategy for other packages.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
package.json(1 hunks)packages/utils/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/utils/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-06T14:40:39.253Z
Learnt from: lifeiscontent
Repo: makeplane/plane PR: 7888
File: packages/propel/package.json:74-79
Timestamp: 2025-10-06T14:40:39.253Z
Learning: When reviewing package.json dependency version updates, verify each package version individually on the npm registry before claiming a version doesn't exist. Different packages within the same organization may have different latest versions.
Applied to files:
package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build and lint web apps
- GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
package.json (1)
20-21: Confirm whetherprettier-plugin-tailwindcssremoval is intentional.The removal of
prettier-plugin-tailwindcssis confirmed. The project actively uses Tailwind CSS (many className attributes with Tailwind utilities found throughout the codebase), but the plugin is no longer listed in.prettierrc. Without this plugin, Prettier will no longer automatically sort Tailwind class names.
- Version compatibility verified:
@prettier/plugin-oxc@0.0.4is compatible withprettier@^3.6.2.- Tailwind class sorting impact: Clarify whether automatic class sorting is still needed. If so, the plugin should be retained alongside the oxc plugin (they serve different purposes—oxc is a parser, not a class sorter).
Co-authored-by: sriramveeraghanta <veeraghanta.sriram@gmail.com>
Co-authored-by: sriramveeraghanta <veeraghanta.sriram@gmail.com>
Co-authored-by: sriramveeraghanta <veeraghanta.sriram@gmail.com>
Type of Change
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.