chore: add permanent redirects for /spaces and /god-mode in Caddyfile#8236
chore: add permanent redirects for /spaces and /god-mode in Caddyfile#8236sriramveeraghanta merged 1 commit intopreviewfrom
Conversation
WalkthroughTwo permanent URL redirects are added to the Caddyfile: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/proxy/Caddyfile.ce (1)
6-9: Trailing‑slash 301s are correct; consider query‑string behaviorBoth
redirlines are syntactically valid and will do what you intend: for exact/spacesand/god-moderequests, Caddy will issue a 301 to the trailing‑slash variant before the correspondingreverse_proxyhandlers run, with no redirect loop. (caddyserver.com)One nuance: a request like
/spaces?tab=all(or/god-mode?foo=bar) will be redirected to/spaces/(or/god-mode/) without the query string, because the<to>argument does not include{uri}or{query}. If callers may rely on query params on those bare paths, you might want to preserve them, e.g. using a smallhandleblock and{query}as shown in the Caddy community docs. (caddy.community)If you want to double‑check the desired behavior, please verify against the latest Caddy
redirand request‑matcher docs to ensure query handling matches your expectations.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/proxy/Caddyfile.ce(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (javascript)
Description
Type of Change
Screenshots and Media (if applicable)
Test Scenarios
References
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.