[WEB-5576] fix: remove optionsClassName from email and workspace forms; add custom scrollbar styles and shadow utility in globals.css#8240
Conversation
…s; add custom scrollbar styles and shadow utility in globals.css
|
Linked to Plane Work Item(s) This comment was auto-generated by Plane |
WalkthroughThis pull request removes a styling prop from CustomSelect components in two forms and enhances the global stylesheet with new scrollbar utilities and custom shadow/blur classes. All changes are presentation-focused with no modifications to application logic or control flow. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/admin/app/(all)/(dashboard)/email/email-config-form.tsx(0 hunks)apps/admin/app/(all)/(dashboard)/workspace/create/form.tsx(0 hunks)apps/admin/styles/globals.css(2 hunks)
💤 Files with no reviewable changes (2)
- apps/admin/app/(all)/(dashboard)/workspace/create/form.tsx
- apps/admin/app/(all)/(dashboard)/email/email-config-form.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build and lint web apps
- GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
apps/admin/styles/globals.css (3)
299-301: Verify global scrollbar hide doesn't break existing components.Hiding scrollbars globally via
::-webkit-scrollbar { display: none; }is a significant change. While the opt-in utility classes (.vertical-scrollbar,.horizontal-scrollbar,.scrollbar-xs/sm/md/lg) provide a way to re-enable them, confirm that:
- All components that require scrollbars are using one of these utility classes.
- The Firefox equivalent (
scrollbar-width: nonein the@-moz-documentblock) is properly scoped.- No unintended visual regressions occur in dropdown menus or other scrollable UI elements.
363-370: Scrollbar utility pattern is consistent and well-structured.The new
.scrollbar-xsvariant follows the existing pattern used by.scrollbar-sm/md/lgand integrates cleanly with the global scrollbar handling. No issues identified.
372-374: Shadow utility is correctly defined.The
.shadow-customclass applies a valid box-shadow with RGBA values. The inline comment accurately documents the hex-to-RGB conversion.
| .backdrop-blur-custom { | ||
| @apply backdrop-filter blur-[9px]; | ||
| } |
There was a problem hiding this comment.
Fix incorrect Tailwind syntax in .backdrop-blur-custom.
The correct Tailwind syntax for backdrop blur uses backdrop-blur-* utilities. The current code uses @apply backdrop-filter blur-[9px], which is incorrect: backdrop-filter is a CSS property (not a Tailwind utility), and blur-[9px] is for element blur, not backdrop blur.
Apply this diff to fix the syntax:
-.backdrop-blur-custom {
- @apply backdrop-filter blur-[9px];
-}
+.backdrop-blur-custom {
+ @apply backdrop-blur-[9px];
+}Alternatively, use raw CSS if you prefer not to use @apply:
-.backdrop-blur-custom {
- @apply backdrop-filter blur-[9px];
-}
+.backdrop-blur-custom {
+ backdrop-filter: blur(9px);
+}🤖 Prompt for AI Agents
In apps/admin/styles/globals.css around lines 376-378, the .backdrop-blur-custom
rule uses incorrect Tailwind syntax (@apply backdrop-filter blur-[9px]); remove
the non-utility backdrop-filter and element blur utility and replace with the
correct backdrop utility, e.g. use @apply backdrop-blur-[9px]; (or, if you
prefer raw CSS, set backdrop-filter: blur(9px); directly) so the class applies a
backdrop blur rather than an element blur.
Description
Type of Change
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.