Skip to content

fix(CI): upgrade prettier oxc plugin version#8242

Merged
sriramveeraghanta merged 2 commits intopreviewfrom
fix-prettier-oxc-mismatch
Dec 4, 2025
Merged

fix(CI): upgrade prettier oxc plugin version#8242
sriramveeraghanta merged 2 commits intopreviewfrom
fix-prettier-oxc-mismatch

Conversation

@sriramveeraghanta
Copy link
Member

@sriramveeraghanta sriramveeraghanta commented Dec 4, 2025

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

  • Chores

    • Updated development formatting toolchain and dev-dependencies across the repository.
  • Bug Fixes

    • Adjusted core modal state logic for more consistent modal behavior (prevents the issue-creation modal alone from marking the core modal set as active).
    • Fixed onboarding profile check to avoid errors when instance configuration is unavailable.

✏️ Tip: You can customize this high-level summary in your review settings.

Copilot AI review requested due to automatic review settings December 4, 2025 12:52
@sriramveeraghanta sriramveeraghanta changed the title fix: upgrade prettier oxc plugin version fix(CI): upgrade prettier oxc plugin version Dec 4, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 4, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Bumps @prettier/plugin-oxc across many package.json files, removes prettier from apps/web/package.json, reforms TypeScript formatting (extends/generics), and removes isCreateIssueModalOpen from the core modals predicate in base-command-palette.store.ts.

Changes

Cohort / File(s) Summary
Dependency updates: Prettier plugin
apps/{admin,live,space}/package.json, apps/web/package.json, package.json, packages/{constants,decorators,editor,hooks,i18n,logger,propel,services,shared-state,types,ui,utils}/package.json
Bumped devDependency @prettier/plugin-oxc from 0.0.40.1.3. Also removed prettier from apps/web/package.json.
Behavioral change: modal state
apps/web/core/store/base-command-palette.store.ts
Removed isCreateIssueModalOpen from getCoreModalsState() predicate — core modal check no longer treats the issue-creation modal as a core modal.
TS formatting: extends / Pick / Omit
apps/space/core/types/issue.d.ts, apps/web/core/components/editor/sticky-editor/editor.tsx, apps/web/core/store/issue/issue-details/root.store.ts, packages/types/src/issues/issue.ts
Reflowed/reformatted extends / Pick / Omit clauses; no semantic changes to types or exported APIs.
TS formatting: generics & class declarations
packages/shared-state/src/store/rich-filters/{adapter,config-manager,config,filter-helpers}.ts
Reformatted generic parameter lists and implements/extends lines (multi-line, trailing commas); no behavioral changes.
TS formatting: base layouts & props
packages/types/src/base-layouts/{base,gantt/index}.ts, packages/ui/src/auth-form/auth-confirm-password-input.tsx
Adjusted line breaks in interface and prop extends clauses; no signature or type changes.
Misc: import & guard fix
apps/web/core/components/onboarding/steps/profile/root.tsx
Replaced duplicate useInstance import and added optional chaining (instanceConfig?.is_self_managed) in MarketingConsent check.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Review focus:
    • apps/web/core/store/base-command-palette.store.ts — ensure UI/modal behavior remains correct when only the create-issue modal is open.
    • apps/web/core/components/onboarding/steps/profile/root.tsx — confirm import de-duplication and optional chaining are correct and safe.
  • Remaining changes are repetitive dependency bumps and formatting edits requiring light verification.

Possibly related PRs

Poem

🐰
OXC updated, quiet and spry,
Lines aligned beneath the sky,
Generics hop, extends in tune,
Modals changed beneath the moon,
A tiny rabbit hums — code improved!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely incomplete, missing critical sections including a detailed description of changes, test scenarios, and references. Only the Type of Change section is partially filled. Add a detailed description of why the prettier oxc plugin was upgraded, the impact on the codebase, test scenarios performed, and any related issue references.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: upgrading the prettier oxc plugin version across multiple package.json files and associated formatting adjustments.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 64fd44c and e1e2d1b.

📒 Files selected for processing (1)
  • apps/web/core/components/onboarding/steps/profile/root.tsx (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the @prettier/plugin-oxc package from version 0.0.4 to 0.1.3 across the entire monorepo. The oxc plugin is a fast Prettier plugin that uses the Rust-based oxc-parser for formatting TypeScript and JavaScript code. The upgrade includes corresponding updates to the underlying oxc-parser (0.74.0 → 0.99.0) and related dependencies.

  • Consistent version bump from 0.0.4 to 0.1.3 across all workspace packages
  • Formatting improvements applied automatically by the new plugin version (multi-line type declarations)
  • Removal of duplicate prettier dependency from apps/web (now inherits from root)

Reviewed changes

Copilot reviewed 27 out of 30 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pnpm-lock.yaml Updated @prettier/plugin-oxc to 0.1.3, oxc-parser to 0.99.0, all native bindings to 0.99.0, and removed prettier@3.6.2; updated @oxc-project/types to 0.99.0
package.json Updated @prettier/plugin-oxc to 0.1.3 in root devDependencies
apps/admin/package.json Updated @prettier/plugin-oxc to 0.1.3 in devDependencies
apps/live/package.json Updated @prettier/plugin-oxc to 0.1.3 in devDependencies
apps/space/package.json Updated @prettier/plugin-oxc to 0.1.3 in devDependencies
apps/web/package.json Updated @prettier/plugin-oxc to 0.1.3 and removed duplicate prettier dependency
packages/constants/package.json Updated @prettier/plugin-oxc to 0.1.3 in devDependencies
packages/decorators/package.json Updated @prettier/plugin-oxc to 0.1.3 in devDependencies
packages/editor/package.json Updated @prettier/plugin-oxc to 0.1.3 in devDependencies
packages/hooks/package.json Updated @prettier/plugin-oxc to 0.1.3 in devDependencies
packages/i18n/package.json Updated @prettier/plugin-oxc to 0.1.3 in devDependencies
packages/logger/package.json Updated @prettier/plugin-oxc to 0.1.3 in devDependencies
packages/propel/package.json Updated @prettier/plugin-oxc to 0.1.3 in devDependencies
packages/services/package.json Updated @prettier/plugin-oxc to 0.1.3 in devDependencies
packages/shared-state/package.json Updated @prettier/plugin-oxc to 0.1.3 in devDependencies
packages/types/package.json Updated @prettier/plugin-oxc to 0.1.3 in devDependencies
packages/ui/package.json Updated @prettier/plugin-oxc to 0.1.3 in devDependencies
packages/utils/package.json Updated @prettier/plugin-oxc to 0.1.3 in devDependencies
packages/ui/src/auth-form/auth-confirm-password-input.tsx Reformatted interface declaration with improved line breaks
packages/types/src/issues/issue.ts Reformatted IPublicIssue interface declaration with improved line breaks
packages/types/src/base-layouts/gantt/index.ts Reformatted IBaseLayoutsGanttProps interface declaration with improved line breaks
packages/types/src/base-layouts/base.ts Reformatted interface declarations with improved line breaks
packages/shared-state/src/store/rich-filters/filter-helpers.ts Reformatted FilterInstanceHelper class declaration with improved line breaks
packages/shared-state/src/store/rich-filters/config.ts Reformatted FilterConfig interface and class declarations with improved line breaks
packages/shared-state/src/store/rich-filters/config-manager.ts Reformatted FilterConfigManager class declaration with improved line breaks
packages/shared-state/src/store/rich-filters/adapter.ts Reformatted FilterAdapter class declaration with improved line breaks
apps/web/core/store/issue/issue-details/root.store.ts Reformatted IIssueDetail interface declaration with improved line breaks
apps/web/core/store/base-command-palette.store.ts Improved indentation in boolean expression chain
apps/web/core/components/editor/sticky-editor/editor.tsx Reformatted StickyEditorWrapperProps interface declaration with improved line breaks
apps/space/core/types/issue.d.ts Reformatted IIssue interface declaration with improved line breaks
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)
apps/web/package.json (1)

15-17: Critical: prettier package missing but scripts require it.

The prettier devDependency is missing from this file while check:format and fix:format scripts (lines 15–17) invoke the prettier CLI. The @prettier/plugin-oxc 0.1.3 plugin requires prettier >= 3.6, and these format scripts will fail without it.

Add prettier to devDependencies with version ^3.6.0 or higher:

  "devDependencies": {
    "@dotenvx/dotenvx": "catalog:",
    "@plane/eslint-config": "workspace:*",
    "@plane/tailwind-config": "workspace:*",
    "@plane/typescript-config": "workspace:*",
    "@prettier/plugin-oxc": "0.1.3",
+   "prettier": "^3.6.0",
    "@react-router/dev": "catalog:",
packages/ui/src/auth-form/auth-confirm-password-input.tsx (1)

5-18: autoComplete prop is declared but effectively ignored

The AuthConfirmPasswordInputProps interface exposes an autoComplete?: "on" | "off" prop, but the component always renders autoComplete="on" on <AuthInput />, so callers cannot override it and the prop type is misleading.

Consider either wiring the prop through or removing it from the public surface. For example, to respect the prop while keeping a default:

-export function AuthConfirmPasswordInput({
-  password,
-  label = "Confirm Password",
-  error,
-  showPasswordToggle = true,
-  containerClassName = "",
-  errorClassName = "",
-  className = "",
-  value = "",
-  onChange,
-  onPasswordMatchChange,
-  ...props
-}: AuthConfirmPasswordInputProps) {
+export function AuthConfirmPasswordInput({
+  password,
+  label = "Confirm Password",
+  error,
+  showPasswordToggle = true,
+  containerClassName = "",
+  errorClassName = "",
+  className = "",
+  value = "",
+  onChange,
+  autoComplete = "on",
+  onPasswordMatchChange,
+  ...props
+}: AuthConfirmPasswordInputProps) {
@@
-      <AuthInput
-        {...props}
+      <AuthInput
+        {...props}
@@
-        autoComplete="on"
+        autoComplete={autoComplete}
       />

Also applies to: 60-76

♻️ Duplicate comments (6)
apps/admin/package.json (1)

55-55: Version mismatch: @prettier/plugin-oxc 0.1.3 does not exist on npm.

This mirrors the same issue from apps/space/package.json. Only version 0.1.2 and earlier versions are available. Update to 0.1.2 to match the latest stable release.

packages/editor/package.json (1)

83-83: Version mismatch: @prettier/plugin-oxc 0.1.3 does not exist on npm.

The latest released version is 0.1.2. This version mismatch exists across all package.json files in this PR and will cause install failures. Update to 0.1.2.

packages/utils/package.json (1)

48-48: Version mismatch: @prettier/plugin-oxc 0.1.3 does not exist on npm.

packages/shared-state/package.json (1)

30-30: Version mismatch: @prettier/plugin-oxc 0.1.3 does not exist on npm.

apps/web/package.json (1)

83-83: Version mismatch: @prettier/plugin-oxc 0.1.3 does not exist on npm.

packages/ui/package.json (1)

63-63: Version mismatch: @prettier/plugin-oxc 0.1.3 does not exist on npm.

🧹 Nitpick comments (2)
packages/shared-state/src/store/rich-filters/config-manager.ts (1)

54-61: JSDoc generics are slightly out of sync with class signature

The FilterConfigManager JSDoc still documents a @template V filter value generic, but the class now only has <P, E>. Consider updating the comment to drop V (or reintroduce it in the type parameters if that’s intended) so tooling and readers don’t get confused.

- * @template P - The filter property type extending TFilterProperty
- * @template V - The filter value type extending TFilterValue
- * @template E - The external filter type extending TExternalFilter
+ * @template P - The filter property type extending TFilterProperty
+ * @template E - The external filter type extending TExternalFilter
packages/shared-state/src/store/rich-filters/filter-helpers.ts (1)

70-76: Align JSDoc template name with class generic parameter

The comment documents @template K but the class is declared as FilterInstanceHelper<P, E>. Renaming the template in the JSDoc to P will avoid confusion:

- * @template K - The filter property type extending TFilterProperty
+ * @template P - The filter property type extending TFilterProperty
 * @template E - The external filter type extending TExternalFilter

The formatting change to the generic parameter list itself is fine and behavior-preserving.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1090b3e and 64fd44c.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (29)
  • apps/admin/package.json (1 hunks)
  • apps/live/package.json (1 hunks)
  • apps/space/core/types/issue.d.ts (1 hunks)
  • apps/space/package.json (1 hunks)
  • apps/web/core/components/editor/sticky-editor/editor.tsx (1 hunks)
  • apps/web/core/store/base-command-palette.store.ts (1 hunks)
  • apps/web/core/store/issue/issue-details/root.store.ts (1 hunks)
  • apps/web/package.json (1 hunks)
  • package.json (1 hunks)
  • packages/constants/package.json (1 hunks)
  • packages/decorators/package.json (1 hunks)
  • packages/editor/package.json (1 hunks)
  • packages/hooks/package.json (1 hunks)
  • packages/i18n/package.json (1 hunks)
  • packages/logger/package.json (1 hunks)
  • packages/propel/package.json (1 hunks)
  • packages/services/package.json (1 hunks)
  • packages/shared-state/package.json (1 hunks)
  • packages/shared-state/src/store/rich-filters/adapter.ts (1 hunks)
  • packages/shared-state/src/store/rich-filters/config-manager.ts (1 hunks)
  • packages/shared-state/src/store/rich-filters/config.ts (2 hunks)
  • packages/shared-state/src/store/rich-filters/filter-helpers.ts (1 hunks)
  • packages/types/package.json (1 hunks)
  • packages/types/src/base-layouts/base.ts (2 hunks)
  • packages/types/src/base-layouts/gantt/index.ts (1 hunks)
  • packages/types/src/issues/issue.ts (1 hunks)
  • packages/ui/package.json (1 hunks)
  • packages/ui/src/auth-form/auth-confirm-password-input.tsx (1 hunks)
  • packages/utils/package.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,mts,cts}

📄 CodeRabbit inference engine (.github/instructions/typescript.instructions.md)

**/*.{ts,tsx,mts,cts}: Use const type parameters for more precise literal inference in TypeScript 5.0+
Use the satisfies operator to validate types without widening them
Leverage inferred type predicates to reduce the need for explicit is return types in filter/check functions
Use NoInfer<T> utility to block inference for specific type arguments when they should be determined by other arguments
Utilize narrowing in switch(true) blocks for control flow analysis (TypeScript 5.3+)
Rely on narrowing from direct boolean comparisons for type guards
Trust preserved narrowing in closures when variables aren't modified after the check (TypeScript 5.4+)
Use constant indices to narrow object/array properties (TypeScript 5.5+)
Use standard ECMAScript decorators (Stage 3) instead of legacy experimentalDecorators
Use using declarations for explicit resource management with Disposable pattern instead of manual cleanup (TypeScript 5.2+)
Use with { type: "json" } for import attributes; avoid deprecated assert syntax (TypeScript 5.3/5.8+)
Use import type explicitly when importing types to ensure they are erased during compilation, respecting verbatimModuleSyntax flag
Use .ts, .mts, .cts extensions in import type statements (TypeScript 5.2+)
Use import type { Type } from "mod" with { "resolution-mode": "import" } for specific module resolution contexts (TypeScript 5.3+)
Use new iterator methods (map, filter, etc.) if targeting modern environments (TypeScript 5.6+)
Utilize new Set methods like union, intersection, etc., when available (TypeScript 5.5+)
Use Object.groupBy / Map.groupBy standard methods for grouping instead of external libraries (TypeScript 5.4+)
Use Promise.withResolvers() for creating promises with exposed resolve/reject functions (TypeScript 5.7+)
Use copying array methods (toSorted, toSpliced, with) for immutable array operations (TypeScript 5.2+)
Avoid accessing instance fields via super in classes (TypeScript 5....

Files:

  • packages/ui/src/auth-form/auth-confirm-password-input.tsx
  • packages/shared-state/src/store/rich-filters/adapter.ts
  • packages/shared-state/src/store/rich-filters/filter-helpers.ts
  • packages/types/src/base-layouts/gantt/index.ts
  • apps/web/core/components/editor/sticky-editor/editor.tsx
  • apps/web/core/store/issue/issue-details/root.store.ts
  • packages/shared-state/src/store/rich-filters/config.ts
  • apps/web/core/store/base-command-palette.store.ts
  • packages/shared-state/src/store/rich-filters/config-manager.ts
  • packages/types/src/base-layouts/base.ts
  • apps/space/core/types/issue.d.ts
  • packages/types/src/issues/issue.ts
🧠 Learnings (10)
📚 Learning: 2025-08-29T08:45:15.953Z
Learnt from: sriramveeraghanta
Repo: makeplane/plane PR: 7672
File: pnpm-workspace.yaml:8-9
Timestamp: 2025-08-29T08:45:15.953Z
Learning: The makeplane/plane repository uses pnpm v10.12.1, which supports onlyBuiltDependencies configuration in pnpm-workspace.yaml files.

Applied to files:

  • packages/shared-state/package.json
  • packages/ui/package.json
  • packages/services/package.json
  • apps/space/package.json
  • packages/constants/package.json
  • apps/web/package.json
  • packages/logger/package.json
  • packages/utils/package.json
  • packages/types/package.json
  • packages/decorators/package.json
  • packages/propel/package.json
  • packages/hooks/package.json
  • packages/editor/package.json
  • apps/admin/package.json
  • packages/i18n/package.json
  • apps/live/package.json
📚 Learning: 2025-11-25T10:17:39.709Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: .github/instructions/bash.instructions.md:0-0
Timestamp: 2025-11-25T10:17:39.709Z
Learning: Applies to {turbo.json,**/*.sh} : Use Turbo for build system orchestration with configuration in turbo.json

Applied to files:

  • package.json
📚 Learning: 2025-11-25T10:18:05.172Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: .github/instructions/typescript.instructions.md:0-0
Timestamp: 2025-11-25T10:18:05.172Z
Learning: Applies to **/*.{ts,tsx,mts,cts} : Leverage inferred type predicates to reduce the need for explicit `is` return types in filter/check functions

Applied to files:

  • packages/shared-state/src/store/rich-filters/filter-helpers.ts
  • packages/shared-state/src/store/rich-filters/config.ts
📚 Learning: 2025-11-25T10:18:05.172Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: .github/instructions/typescript.instructions.md:0-0
Timestamp: 2025-11-25T10:18:05.172Z
Learning: Applies to **/*.{ts,tsx,mts,cts} : Treat legacy `experimentalDecorators`-style behavior as deprecated in favor of standard TC39-compliant decorators

Applied to files:

  • apps/web/core/components/editor/sticky-editor/editor.tsx
📚 Learning: 2025-11-25T10:18:05.172Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: .github/instructions/typescript.instructions.md:0-0
Timestamp: 2025-11-25T10:18:05.172Z
Learning: Applies to **/*.{ts,tsx,mts,cts} : Use `const` type parameters for more precise literal inference in TypeScript 5.0+

Applied to files:

  • apps/web/core/components/editor/sticky-editor/editor.tsx
📚 Learning: 2025-11-25T10:18:05.172Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: .github/instructions/typescript.instructions.md:0-0
Timestamp: 2025-11-25T10:18:05.172Z
Learning: Applies to **/*.{ts,tsx,mts,cts} : Use standard ECMAScript decorators (Stage 3) instead of legacy `experimentalDecorators`

Applied to files:

  • apps/web/core/components/editor/sticky-editor/editor.tsx
  • packages/types/package.json
📚 Learning: 2025-11-25T10:18:05.172Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: .github/instructions/typescript.instructions.md:0-0
Timestamp: 2025-11-25T10:18:05.172Z
Learning: Applies to **/*.{ts,tsx,mts,cts} : Trust preserved narrowing in closures when variables aren't modified after the check (TypeScript 5.4+)

Applied to files:

  • apps/web/core/components/editor/sticky-editor/editor.tsx
📚 Learning: 2025-10-09T20:42:31.843Z
Learnt from: lifeiscontent
Repo: makeplane/plane PR: 7922
File: apps/admin/app/(all)/(dashboard)/ai/form.tsx:19-19
Timestamp: 2025-10-09T20:42:31.843Z
Learning: In the makeplane/plane repository, React types are globally available through TypeScript configuration. Type annotations like React.FC, React.ReactNode, etc. can be used without explicitly importing the React namespace. The codebase uses the modern JSX transform, so React imports are not required for JSX or type references.

Applied to files:

  • packages/types/package.json
  • packages/editor/package.json
📚 Learning: 2025-11-25T10:18:05.172Z
Learnt from: CR
Repo: makeplane/plane PR: 0
File: .github/instructions/typescript.instructions.md:0-0
Timestamp: 2025-11-25T10:18:05.172Z
Learning: Applies to **/*.{ts,tsx,mts,cts} : Use `Object.groupBy` / `Map.groupBy` standard methods for grouping instead of external libraries (TypeScript 5.4+)

Applied to files:

  • packages/types/src/base-layouts/base.ts
📚 Learning: 2025-06-16T07:23:39.497Z
Learnt from: vamsikrishnamathala
Repo: makeplane/plane PR: 7214
File: web/core/store/issue/helpers/base-issues.store.ts:117-117
Timestamp: 2025-06-16T07:23:39.497Z
Learning: In the updateIssueDates method of BaseIssuesStore (web/core/store/issue/helpers/base-issues.store.ts), the projectId parameter is intentionally made optional to support override implementations in subclasses. The base implementation requires projectId and includes an early return check, but making it optional allows derived classes to override the method with different parameter requirements.

Applied to files:

  • apps/space/core/types/issue.d.ts
  • packages/types/src/issues/issue.ts
🧬 Code graph analysis (6)
packages/shared-state/src/store/rich-filters/filter-helpers.ts (2)
packages/types/src/rich-filters/expression.ts (1)
  • TFilterProperty (19-19)
packages/types/src/rich-filters/adapter.ts (1)
  • TExternalFilter (7-7)
packages/types/src/base-layouts/gantt/index.ts (1)
packages/types/src/base-layouts/base.ts (1)
  • IBaseLayoutsBaseProps (64-77)
apps/web/core/components/editor/sticky-editor/editor.tsx (1)
packages/editor/src/core/types/editor.ts (1)
  • ILiteTextEditorProps (173-173)
apps/web/core/store/issue/issue-details/root.store.ts (1)
apps/web/core/store/issue/issue-details/issue.store.ts (1)
  • IIssueStoreActions (11-29)
packages/shared-state/src/store/rich-filters/config-manager.ts (2)
packages/types/src/rich-filters/expression.ts (1)
  • TFilterProperty (19-19)
packages/types/src/rich-filters/adapter.ts (1)
  • TExternalFilter (7-7)
apps/space/core/types/issue.d.ts (1)
packages/types/src/issues/issue.ts (1)
  • TIssue (84-98)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Agent
  • GitHub Check: CodeQL analysis (javascript-typescript)
  • GitHub Check: Build and lint web apps
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (20)
packages/types/src/base-layouts/base.ts (1)

81-82: Formatting changes to interface extends clauses look good.

The line-wrapping of extends clauses in IBaseLayoutsBaseGroupProps (lines 81–82) and IBaseLayoutsBaseItemProps (lines 93–94) is consistent with Prettier's reformatting style and introduces no semantic changes. No changes to public type relationships or exports.

Also applies to: 93-94

apps/space/package.json (1)

59-59: Version 0.1.3 of @prettier/plugin-oxc does not exist; latest stable is 0.0.4.

The PR targets version 0.1.3, but the actual latest released version on npm is 0.0.4 (published June 24, 2025). The attempted version 0.1.3 is not available and will cause npm/pnpm install to fail. Update to the latest stable version:

-    "@prettier/plugin-oxc": "0.1.3",
+    "@prettier/plugin-oxc": "0.0.4",

Likely an incorrect or invalid review comment.

package.json (1)

21-21: Consistent version bump across monorepo.

The @prettier/plugin-oxc version is uniformly updated to 0.1.3. Ensure this version exists and is compatible with the current Prettier version (^3.7.3).

apps/live/package.json (1)

58-58: Version bump aligns with monorepo updates.

packages/services/package.json (1)

33-33: Consistent version bump.

packages/decorators/package.json (1)

25-25: Consistent version bump.

packages/types/package.json (1)

28-28: Consistent version bump.

packages/i18n/package.json (1)

36-36: Consistent version bump.

packages/propel/package.json (1)

87-87: Consistent version bump.

packages/constants/package.json (1)

23-23: Consistent version bump.

packages/hooks/package.json (1)

29-32: @prettier/plugin-oxc version bump is tooling-only and looks fine

DevDependency update to 0.1.3 is scoped to formatting and shouldn’t affect runtime behavior; consistent with the PR’s goal.

Please verify that this version matches the root tooling setup and that pnpm lint / pnpm prettier still pass across the workspace.

packages/types/src/base-layouts/gantt/index.ts (1)

58-63: Readable reflow of IBaseLayoutsGanttProps extends list

Only the line breaks around the extends clause changed; the type surface and omitted keys are unchanged, so this is a safe formatting improvement.

packages/logger/package.json (1)

26-30: Logger package prettier-oxc bump matches the tooling change

Updating @prettier/plugin-oxc to 0.1.3 here aligns this package with the repo-wide formatter setup; no runtime effect expected.

After upgrading, confirm that formatting commands for this package (e.g., pnpm check:format in packages/logger) still behave as expected.

apps/web/core/store/issue/issue-details/root.store.ts (1)

62-73: IIssueDetail extends clause reflow is cosmetic and safe

The extends list is just split over multiple lines; the same action/store interfaces are still implemented, so there’s no behavioral or typing change here.

apps/web/core/components/editor/sticky-editor/editor.tsx (1)

18-37: StickyEditorWrapperProps extends formatting only

The nested Omit chain and excluded keys are unchanged; this is purely a style/formatting tweak, so the component’s props surface remains the same.

apps/space/core/types/issue.d.ts (1)

36-59: IIssue Pick<> formatting-only change looks safe

The Pick<TIssue, ...> key set is unchanged; only line-wrapping/placement of the > and { moved. No semantic or typing impact, so this is safe to ship.

packages/shared-state/src/store/rich-filters/adapter.ts (1)

11-14: FilterAdapter implements clause reflow is non-semantic

The FilterAdapter<K, E> generics and IFilterAdapter<K, E> implementation remain identical; only line breaks changed. No runtime or type-level behavior change here.

apps/web/core/store/base-command-palette.store.ts (1)

92-100: getCoreModalsState aggregation remains consistent with intent

The updated OR chain still reflects “any base modal is open”: all relevant modal flags plus createPageModal.isOpen and allStickiesModal are included, with no loss of coverage. This keeps callers’ semantics intact.

packages/shared-state/src/store/rich-filters/config.ts (1)

28-31: FilterConfig/IFilterConfig generic signatures unchanged

Both IFilterConfig and FilterConfig keep the same generic parameters, default type argument, and base/implemented types; only the extends/implements clauses were reflowed. No impact on consumers or behavior.

Also applies to: 49-52

packages/types/src/issues/issue.ts (1)

156-179: IPublicIssue Pick<> key list is structurally unchanged

The same TIssue properties are being picked; only the formatting of the multi-line key union and > placement changed. Public API shape for IPublicIssue is preserved.

@sriramveeraghanta sriramveeraghanta merged commit c390604 into preview Dec 4, 2025
4 of 5 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix-prettier-oxc-mismatch branch December 4, 2025 12:57
ClarenceChen0627 pushed a commit to ClarenceChen0627/plane that referenced this pull request Dec 5, 2025
* fix: upgrade prettier oxc plugin version

* fix: type errors
ClarenceChen0627 pushed a commit to ClarenceChen0627/plane that referenced this pull request Dec 5, 2025
* fix: upgrade prettier oxc plugin version

* fix: type errors
ClarenceChen0627 pushed a commit to ClarenceChen0627/plane that referenced this pull request Dec 5, 2025
* fix: upgrade prettier oxc plugin version

* fix: type errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants