-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[WEB-5657] feat: add synchronization configuration for multiple providers in authentication adapter #8336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[WEB-5657] feat: add synchronization configuration for multiple providers in authentication adapter #8336
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
657dc4c
feat: add sync functionality for OAuth providers
pablohashescobar c3f6d5b
feat: add sync toggle for OAuth providers in configuration forms
b-saikrishnakanth f1d87b3
fix: remove default value for sync options in OAuth configuration forms
b-saikrishnakanth e442cc3
Merge branch 'preview' of github.com:makeplane/plane into auth-sync
pablohashescobar 34db14b
chore: delete old avatar and upload a new one
pablohashescobar 0df31a8
resolve: merge conflict
pablohashescobar a415f5b
chore: update class method
pablohashescobar 1601f76
chore: add email nullable
pablohashescobar 4576b20
refactor: streamline sync check for multiple providers and improve av…
pablohashescobar 88562c5
fix: ensure ENABLE_SYNC configurations default to "0" for Gitea, Gith…
b-saikrishnakanth 888b364
Merge branch 'auth-sync' of github.com:makeplane/plane into auth-sync
b-saikrishnakanth bc57b22
fix: simplify toggle switch value handling in ControllerSwitch component
b-saikrishnakanth 38f97d0
Merge branch 'preview' of github.com:makeplane/plane into auth-sync
b-saikrishnakanth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import type { Control, FieldPath, FieldValues } from "react-hook-form"; | ||
| import { Controller } from "react-hook-form"; | ||
| // plane internal packages | ||
| import { ToggleSwitch } from "@plane/ui"; | ||
|
|
||
| type Props<T extends FieldValues = FieldValues> = { | ||
| control: Control<T>; | ||
| field: TControllerSwitchFormField<T>; | ||
| }; | ||
|
|
||
| export type TControllerSwitchFormField<T extends FieldValues = FieldValues> = { | ||
| name: FieldPath<T>; | ||
| label: string; | ||
| }; | ||
|
|
||
| export function ControllerSwitch<T extends FieldValues>(props: Props<T>) { | ||
| const { | ||
| control, | ||
| field: { name, label }, | ||
| } = props; | ||
|
|
||
| return ( | ||
| <div className="flex items-center justify-between gap-1"> | ||
| <h4 className="text-sm text-custom-text-300">Refresh user attributes from {label} during sign in</h4> | ||
| <div className="relative"> | ||
| <Controller | ||
| control={control} | ||
| name={name as FieldPath<T>} | ||
| render={({ field: { value, onChange } }) => ( | ||
| <ToggleSwitch | ||
| value={Boolean(parseInt(value))} | ||
| onChange={() => (parseInt(value) ? onChange("0") : onChange("1"))} | ||
| size="sm" | ||
| /> | ||
| )} | ||
| /> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'size' prop was removed from the Button component but is still present on the other provider forms (Google, GitHub, GitLab all have size="lg"). This inconsistency should be corrected to match the other forms.