Skip to content

fix: custom z-index classNames #8395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pushya22 merged 1 commit into from
Dec 19, 2025
Merged

fix: custom z-index classNames #8395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/propel/src/dialog/root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ export interface DialogTitleProps extends React.ComponentProps<typeof BaseDialog
}

// Constants
const OVERLAY_CLASSNAME = cn("fixed inset-0 z-backdrop bg-backdrop");
const BASE_CLASSNAME = "relative text-left bg-surface-1 rounded-lg shadow-md w-full z-modal border border-subtle";
const OVERLAY_CLASSNAME = cn("fixed inset-0 z-90 bg-backdrop");
const BASE_CLASSNAME = "relative text-left bg-surface-1 rounded-lg shadow-md w-full z-100 border border-subtle";
Comment on lines +38 to +39
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class names z-90 and z-100 are not valid Tailwind CSS classes. In Tailwind, arbitrary z-index values should use bracket notation. Based on the rest of the codebase which uses patterns like z-[35], z-[15], etc., these should be z-[90] and z-[100] instead.

Copilot uses AI. Check for mistakes.

// Utility functions
const getPositionClassNames = (position: DialogPosition) =>
cn("isolate fixed z-modal", {
cn("isolate fixed z-100", {
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class name z-100 is not a valid Tailwind CSS class. In Tailwind, arbitrary z-index values should use bracket notation like z-[100].

Copilot uses AI. Check for mistakes.
Comment on lines +38 to +43
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title and description reference "Tailwind v3", but the project is actually using Tailwind v4.1.17 as confirmed in packages/tailwind-config/package.json. The PR description should be updated to reflect this.

Copilot uses AI. Check for mistakes.
"top-1/2 left-1/2 -translate-x-1/2 -translate-y-1/2": position === "center",
"top-8 left-1/2 -translate-x-1/2": position === "top",
});
Expand Down
Loading