-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[WEB-5779] fix: handle loading state while fetching project cover image #8419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8c0868d
refactor: replace cover image handling with CoverImage component acro…
JayashTripathy 0b819fc
fix: extend CoverImage component to accept additional img props
JayashTripathy bac52b5
Update apps/web/core/components/common/cover-image.tsx
JayashTripathy 5009558
Merge branch 'preview' of https://github.com/makeplane/plane into fix…
JayashTripathy 5443938
Merge branch 'fix/project-default-cover-image' of https://github.com/…
JayashTripathy b0460b5
fix: handle undefined cover image URL in ProfileSidebar component
JayashTripathy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import { cn } from "@plane/utils"; | ||
| // helpers | ||
| import { getCoverImageDisplayURL, DEFAULT_COVER_IMAGE_URL } from "@/helpers/cover-image.helper"; | ||
|
|
||
| type TCoverImageProps = { | ||
| /** The cover image URL - can be static, uploaded, or external */ | ||
| src: string | null | undefined; | ||
| /** Alt text for the image */ | ||
| alt?: string; | ||
| /** Additional className for the image or skeleton */ | ||
| className?: string; | ||
| /** Whether to show default image when src is null/undefined. If false, shows loading skeleton */ | ||
| showDefaultWhenEmpty?: boolean; | ||
| /** Custom fallback URL to use instead of DEFAULT_COVER_IMAGE_URL */ | ||
| fallbackUrl?: string; | ||
| } & React.ComponentProps<"img">; | ||
|
|
||
| /** | ||
| * A reusable cover image component that handles: | ||
| * - Loading states with skeleton | ||
| * - Static images (local assets) | ||
| * - Uploaded images (processed through getFileURL) | ||
| * - External URLs | ||
| * - Fallback to default cover image | ||
| */ | ||
| export function CoverImage(props: TCoverImageProps) { | ||
| const { | ||
| src, | ||
| alt = "Cover image", | ||
| className, | ||
| showDefaultWhenEmpty = false, | ||
| fallbackUrl = DEFAULT_COVER_IMAGE_URL, | ||
| ...restProps | ||
| } = props; | ||
|
|
||
| // Show loading skeleton when src is undefined/null and we don't want to show default | ||
| if (!src && !showDefaultWhenEmpty) { | ||
| return <div className={cn("bg-layer-2 animate-pulse", className)} />; | ||
| } | ||
|
|
||
| const displayUrl = getCoverImageDisplayURL(src, fallbackUrl); | ||
|
|
||
| return <img src={displayUrl} alt={alt} className={cn("object-cover", className)} {...restProps} />; | ||
JayashTripathy marked this conversation as resolved.
Show resolved
Hide resolved
JayashTripathy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.