Skip to content

[WEB-6420] chore: self-host social icons in project invitation email #8718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sriramveeraghanta merged 3 commits into from
Mar 5, 2026
Merged

[WEB-6420] chore: self-host social icons in project invitation email #8718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8df880f
chore: add self-hosted social icon assets for email templates
anmolsinghbhatia Mar 5, 2026
157019c
chore: pass current_site to project invitation email context
anmolsinghbhatia Mar 5, 2026
29a2298
chore: replace mailinblue CDN icons with self-hosted static assets
anmolsinghbhatia Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/api/plane/bgtasks/project_invitation_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ def project_invitation(email, project_id, token, current_site, invitor):
"first_name": user.first_name,
"project_name": project.name,
"invitation_url": abs_url,
"current_site": current_site,
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current_site is concatenated into absolute URLs in the email template. If it’s configured with a trailing slash, the rendered image URLs will contain //static/... (and the invitation URL already risks //project-invitations/...). Consider normalizing before adding to the context (e.g., stripping any trailing /) so downstream templates can safely append paths.

Copilot uses AI. Check for mistakes.
}

html_content = render_to_string("emails/invitations/project_invitation.html", context)
Expand Down
Binary file added apps/api/plane/static/logos/github_32px.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added apps/api/plane/static/logos/linkedin_32px.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added apps/api/plane/static/logos/twitter_32px.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added apps/api/plane/static/logos/website_32px.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 4 additions & 4 deletions apps/api/templates/emails/invitations/project_invitation.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@
<td height="5" width="8" style=" font-size: 5px; line-height: 5px; " > ­ </td>
</tr>
<tr>
<td class="r26-i" style=" font-size: 0px; line-height: 0px; " > <a href="https://github.com/makeplane/plane" target="_blank" style=" color: #0092ff; text-decoration: underline; " > <img src="https://creative-assets.mailinblue.com/editor/social-icons/rounded_colored/github_32px.png" width="32" border="0" class="" style=" display: block; width: 100%; " /></a> </td>
<td class="r26-i" style=" font-size: 0px; line-height: 0px; " > <a href="https://github.com/makeplane/plane" target="_blank" style=" color: #0092ff; text-decoration: underline; " > <img src="{{ current_site }}/static/logos/github_32px.png" width="32" border="0" class="" style=" display: block; width: 100%; " /></a> </td>
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These image URLs are hard-coded to /static/logos/...png, but the backend uses whitenoise.storage.CompressedManifestStaticFilesStorage (hashed filenames). After collectstatic, /static/logos/github_32px.png will likely 404 because the emitted filename is hashed. Use Django’s {% static %} tag (and {% load static %}) to render the correct manifest-mapped path, then prepend current_site to make it absolute.

Copilot uses AI. Check for mistakes.
<td class="nl2go-responsive-hide" width="8" style=" font-size: 0px; line-height: 1px; " > ­ </td>
</tr>
<tr class="nl2go-responsive-hide" >
Expand All @@ -244,7 +244,7 @@
<td height="5" width="8" style=" font-size: 5px; line-height: 5px; " > ­ </td>
</tr>
<tr>
<td class="r26-i" style=" font-size: 0px; line-height: 0px; " > <a href="https://forum.plane.so" target="_blank" style=" color: #0092ff; text-decoration: underline; " > <img src="https://creative-assets.mailinblue.com/editor/social-icons/rounded_colored/website_32px.png" width="32" border="0" class="" style=" display: block; width: 100%; " /></a> </td>
<td class="r26-i" style=" font-size: 0px; line-height: 0px; " > <a href="https://forum.plane.so" target="_blank" style=" color: #0092ff; text-decoration: underline; " > <img src="{{ current_site }}/static/logos/website_32px.png" width="32" border="0" class="" style=" display: block; width: 100%; " /></a> </td>
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These image URLs are hard-coded to /static/logos/...png, but the backend uses whitenoise.storage.CompressedManifestStaticFilesStorage (hashed filenames). After collectstatic, /static/logos/website_32px.png will likely 404 because the emitted filename is hashed. Use Django’s {% static %} tag (and {% load static %}) to render the correct manifest-mapped path, then prepend current_site to make it absolute.

Copilot uses AI. Check for mistakes.
<td class="nl2go-responsive-hide" width="8" style=" font-size: 0px; line-height: 1px; " > ­ </td>
</tr>
<tr class="nl2go-responsive-hide" >
Expand All @@ -261,7 +261,7 @@
<td height="5" width="8" style=" font-size: 5px; line-height: 5px; " > ­ </td>
</tr>
<tr>
<td class="r26-i" style=" font-size: 0px; line-height: 0px; " > <a href="https://twitter.com/planepowers" target="_blank" style=" color: #0092ff; text-decoration: underline; " > <img src="https://creative-assets.mailinblue.com/editor/social-icons/rounded_colored/twitter_32px.png" width="32" border="0" class="" style=" display: block; width: 100%; " /></a> </td>
<td class="r26-i" style=" font-size: 0px; line-height: 0px; " > <a href="https://twitter.com/planepowers" target="_blank" style=" color: #0092ff; text-decoration: underline; " > <img src="{{ current_site }}/static/logos/twitter_32px.png" width="32" border="0" class="" style=" display: block; width: 100%; " /></a> </td>
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These image URLs are hard-coded to /static/logos/...png, but the backend uses whitenoise.storage.CompressedManifestStaticFilesStorage (hashed filenames). After collectstatic, /static/logos/twitter_32px.png will likely 404 because the emitted filename is hashed. Use Django’s {% static %} tag (and {% load static %}) to render the correct manifest-mapped path, then prepend current_site to make it absolute.

Copilot uses AI. Check for mistakes.
<td class="nl2go-responsive-hide" width="8" style=" font-size: 0px; line-height: 1px; " > ­ </td>
</tr>
<tr class="nl2go-responsive-hide" >
Expand All @@ -277,7 +277,7 @@
<td height="5" style=" font-size: 5px; line-height: 5px; " > ­ </td>
</tr>
<tr>
<td class="r26-i" style=" font-size: 0px; line-height: 0px; " > <a href="https://www.linkedin.com/company/planepowers/" target="_blank" style=" color: #0092ff; text-decoration: underline; " > <img src="https://creative-assets.mailinblue.com/editor/social-icons/rounded_colored/linkedin_32px.png" width="32" border="0" class="" style=" display: block; width: 100%; " /></a> </td>
<td class="r26-i" style=" font-size: 0px; line-height: 0px; " > <a href="https://www.linkedin.com/company/planepowers/" target="_blank" style=" color: #0092ff; text-decoration: underline; " > <img src="{{ current_site }}/static/logos/linkedin_32px.png" width="32" border="0" class="" style=" display: block; width: 100%; " /></a> </td>
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These image URLs are hard-coded to /static/logos/...png, but the backend uses whitenoise.storage.CompressedManifestStaticFilesStorage (hashed filenames). After collectstatic, /static/logos/linkedin_32px.png will likely 404 because the emitted filename is hashed. Use Django’s {% static %} tag (and {% load static %}) to render the correct manifest-mapped path, then prepend current_site to make it absolute.

Copilot uses AI. Check for mistakes.
</tr>
<tr class="nl2go-responsive-hide" >
<td height="5" style=" font-size: 5px; line-height: 5px; " > ­ </td>
Expand Down
Loading