Skip to content

[WEB-6783] fix: crash when deleting work item from peek view in workspace spreadsheet #8821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sriramveeraghanta merged 2 commits into from
Mar 30, 2026
+5 −2
Merged

[WEB-6783] fix: crash when deleting work item from peek view in workspace spreadsheet #8821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0005974
fix: guard against undefined issue in SpreadsheetIssueRow
anmolsinghbhatia Mar 29, 2026
4eee531
fix: add defensive guard for isIssueNew in list block-root
anmolsinghbhatia Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/web/core/components/issues/issue-layouts/list/block-root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ export const IssueBlockRoot = observer(function IssueBlockRoot(props: Props) {
root={containerRef}
classNames={`relative ${isLastChild && !isExpanded ? "" : "border-b border-b-subtle"}`}
verticalOffset={100}
defaultValue={shouldRenderByDefault || isIssueNew(issuesMap[issueId])}
defaultValue={shouldRenderByDefault || (issuesMap[issueId] ? isIssueNew(issuesMap[issueId]) : false)}
placeholderChildren={<ListLoaderItemRow shouldAnimate={false} renderForPlaceHolder defaultPropertyCount={4} />}
Comment on lines 140 to 142
Copy link

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IssueBlockRoot already returns early when issuesMap[issueId]?.created_at is falsy, so issuesMap[issueId] is guaranteed to exist at this point. The added ternary is redundant and also repeats the map lookup. Consider keeping the previous isIssueNew(issuesMap[issueId]) call, or assign const issue = issuesMap[issueId] after the guard and use that variable for clarity.

Copilot uses AI. Check for mistakes.
shouldRecordHeights={isMobile}
>
Expand Down
5 changes: 4 additions & 1 deletion apps/web/core/components/issues/issue-layouts/spreadsheet/issue-row.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,13 @@ export const SpreadsheetIssueRow = observer(function SpreadsheetIssueRow(props:
const { issueMap } = useIssues();

// derived values
const issue = issueMap[issueId];
const subIssues = subIssuesStore.subIssuesByIssueId(issueId);
const isIssueSelected = selectionHelpers.getIsEntitySelected(issueId);
const isIssueActive = selectionHelpers.getIsEntityActive(issueId);

if (!issue) return null;

return (
<>
{/* first column/ issue name and key column */}
Expand All @@ -104,7 +107,7 @@ export const SpreadsheetIssueRow = observer(function SpreadsheetIssueRow(props:
})}
verticalOffset={100}
shouldRecordHeights={false}
defaultValue={shouldRenderByDefault || isIssueNew(issueMap[issueId])}
defaultValue={shouldRenderByDefault || isIssueNew(issue)}
>
<IssueRowDetails
issueId={issueId}
Expand Down
Loading