[WEB-6784] feat scrollbar in shortcuts modal#8872
[WEB-6784] feat scrollbar in shortcuts modal#8872b-saikrishnakanth wants to merge 4 commits intopreviewfrom
Conversation
|
Linked to Plane Work Item(s) This comment was auto-generated by Plane |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughTwo component files were modified to relocate scrolling responsibility from the ShortcutRenderer component to its parent modal wrapper. A ScrollArea component now handles vertical scrolling of the shortcuts section, while the container layout was adjusted for consistent padding and spacing across modal elements. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/web/core/components/power-k/ui/modal/shortcuts-root.tsx`:
- Around line 89-96: The ScrollArea wrapper and internal shortcuts component are
declaring competing overflow styles; remove the redundant overflow declarations
so ScrollArea manages scrolling exclusively: in the component rendering the
ScrollArea (where ScrollArea is used with scrollType="always" and
orientation="vertical") remove "overflow-y-scroll" from the container className,
and in the ShortcutRenderer component (the root div in shortcut.tsx) remove the
"overflow-y-auto"/overflow styles so ShortcutRenderer no longer creates its own
scroll container; keep ScrollArea props as-is and ensure only ScrollArea
provides scrolling.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0dc5ba50-03a1-4b2f-b383-142158ec21e5
📒 Files selected for processing (2)
apps/web/core/components/power-k/ui/modal/shortcuts-root.tsxapps/web/core/components/project/form.tsx
Description
added scrollbar in keyboard shortcuts modal
Type of Change
Screenshots and Media (if applicable)
Before

After

Test Scenarios
References
Summary by CodeRabbit
New Features
Improvements