[pull] master from rwf2:master#126
Open
pull[bot] wants to merge 14 commits into
Open
Conversation
- Update `gen_certs.sh` - Generate client cert as well by default - Set expiration to 10 years to match other certs - Set subject to match expected values in testbench test - Update testbench `mtls` to ignore key hash value, and only check issuer and subject.
Initialize db_pools without forcing immediate DB connections. Avoid crashing at launch if the database is unavailable or misconfigured. Why: - Databases can be temporarily unavailable; servers shouldn't refuse to start solely due to transient DB issues. - Reduces false failed-deploy signals. Effect: - sqlx backend matches deadpool behavior: pool builds without dialing. - Connection errors now surface when acquiring a connection from the pool, not during fairing init.
- Populates value from hyper version. - Also adds a method to override version for local requests. Co-authored-by: Dan Dumont <dan.dumont@hcl.com>
Rust now warns when it determines that an elided lifetime has a name. This commit updates relevant cases to use the named lifetime instead.
A breaking change in `tracing` (see tracing#3309) resulted in the TLS example breaking. This commit implements the work-around in the issue.
The `Sync` bound on `Pool` is, as far as I can tell, unneeded. `diesel-async`'s mysql connection pool isn't `Sync` anymore, which is why bound needed to be removed. closes: #2969
Grabs the SNI from TLS connections and saves to ConenctionMeta struct. Provides useful methods for exracting the SNI from requests. Closes #2942
Actually check for missing key, since figment doesn't properly decode `Option<bool>` on it's own. closes: #2976
…f typo fixes (#2975) Pastebin example uses now deprecated `rand::gen()` which was changed due to the reserved `gen` keyword in Rust 2024 edition. Rather than changing dependencies or updating the guide to specify an older edition, I've updated to use `gen_range` (should be best practice to avoid an infinitesimal bias anyway). This should work with any edition. Also fixed typos I noticed in the CONTRIBUTING doc. --------- Co-authored-by: Daniel Welsh <danielw2000@gmail.com> Co-authored-by: Matthew Pomes <matthew.pomes@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )