[pull] master from tensorflow:master#1632
Merged
Merged
Conversation
SymbolicTileAnalysis::ToString didn't handle regions correctly. Use spaces instead of tabs. PiperOrigin-RevId: 913214711
Imported from GitHub PR openxla/xla#42259 When setting FFI state via `TypeId` require passing `TypeInfo` as well. Templated APIs are supposed to be used in statically linked binaries, and when different FFI handlers can be in separate object files we rely on opaque type ids and state, and always lookup them through FFI API. This is one more fix required for making "internal" FFI headers "safe" when linked as multiple object files. This is still not safe in general and not recommended, but this is an escape hatch that makes it work correctly when XLA and FFI handler compiled with the same toolchain. Copybara import of the project: -- b3e513f56c2233a5c59ac5328de644df3e00d2ef by Eugene Zhulenev <ezhulenev@openxla.org>: [xla:ffi] When setting opaque state require TypeInfo Merging this change closes #42259 PiperOrigin-RevId: 913250041
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )