Fixing compatibility with the new ASE #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter. The removal doesn't seem to be changing anything in the produced file. In addition replacing 'quit()' for 'return' in hte dftconvergence and md provider, which seems to be better suited for production code and Jupyter notebooks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
long_format=Trueoption is no longer available for the ASE vasp writer (as of the merge 3155 from November 2023). Differences in the produced files seem to be within the round-off error.In addition, this merge replaces 'quit()' with 'return' in the
dftconvergenceandmdproviders, which seems better suited for production code and Jupyter notebooks.