<EVAL>Javascript gets cut off if longer than 4000 characters

[berridgeab]

Weird issue, if JavaScript within an EVAL block exceeds 4000 characters, it seems to truncate the remaining script and then try to execute it. An error will be thrown by javascript due to the script being incomplete. Any ideas?

[berridgeab]

I've managed to resolve the issue. The issue only seems to affect Firefox. I've tested Chrome and I.E and they seem to be unaffected.

Taconite processes nodes. If the node length is too long (Around 4000 characters) Firefox seems to split the nodes up in to multiple nodes. The fix is to process the remaining nodes.

Replace this code within the process() function.

        if (cmd == 'eval') {
            js = (cmdNode.firstChild ? cmdNode.firstChild.nodeValue : null);
            log('invoking "eval" command: ', js);
            if (js)
                $.globalEval(js);
            continue;
        }

With the following

if (cmd == 'eval') {
        js = '';
        for (ii = 0; ii < cmdNode.childNodes.length; ii++) {
                js += cmdNode.childNodes[ii].nodeValue;
        }

        log('invoking "eval" command: ', js);
        if (js.length)
                $.globalEval(js);
        continue;
}

As mentioned before the issue only seems to affect Firefox. Other browsers seem unaffected.

The fix simply loops over all available nodes and appends the data to one variable.