Merged
Conversation
This reverts commit 8f82536.
This reverts commit f4cc0da.
This reverts commit 988e5cb.
pytest 3.7.1 changed behavior for fixture decorators. But later in 3.7.2 this was fixed by __pytest_wrapped__ attribute, which is used to obtain the function up until the point a function was wrapped by pytest itself. Signed-off-by: Stanislav Levin <slev@altlinux.org>
javefang
approved these changes
Jan 8, 2019
Contributor
javefang
left a comment
javefang
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix docs and tests due to pytest 3.7.1
pytest 3.7.1 changed behavior for fixture decorators. But later in 3.7.2 this was fixed by adding of
__pytest_wrapped__attribute, which is used to obtain the function up until the point a function was wrapped by pytest itself.For related info please look at pytest-dev/pytest#3780
Removing of functionality is a surprise for most users/developers.
Meanwhile, fixture_config is used by setuptools for testing.