Skip to content
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .github/rulesets/require-pull-request.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
{
"name": "Require pull request on master/main",
"target": "branch",
"enforcement": "active",
"conditions": {
"ref_name": {
"include": ["refs/heads/master", "refs/heads/main", "refs/heads/dev"],
"exclude": []
}
},
"bypass_actors": [
{
"actor_type": "RepositoryRole",
"actor_id": 5,
"bypass_mode": "always"
}
],
"rules": [
{
"type": "pull_request",
"parameters": {
"required_approving_review_count": 0,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 required_approving_review_count is 0 — PRs required but no reviews enforced

Setting required_approving_review_count to 0 means a pull request is required to merge into the protected branches, but it can be merged without any approving review. Combined with dismiss_stale_reviews_on_push: false, require_code_owner_review: false, and require_last_push_approval: false, the ruleset only enforces that changes go through a PR — not that anyone actually reviews them. This may be intentional (the CONTRIBUTING.md mentions the repo is relatively new and the PR expectations are lightweight), but it's worth confirming this is the desired protection level, especially for main/master.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"dismiss_stale_reviews_on_push": false,
"require_code_owner_review": false,
"require_last_push_approval": false,
"required_review_thread_resolution": false
}
}
]
}