Skip to content

READY: Add columnal list classes#11

Open
tandrewnichols wants to merge 2 commits intomasterfrom
columnal-list
Open

READY: Add columnal list classes#11
tandrewnichols wants to merge 2 commits intomasterfrom
columnal-list

Conversation

@tandrewnichols
Copy link
Copy Markdown

@Delightend @faktorsmak @FabledWeb Add columnal list classes for displaying bulleted lists in multiple columns. (Does not work for IE.)

This needs to be merged before the product list page (as I'm using one of these classes there).

@tandrewnichols
Copy link
Copy Markdown
Author

@FabledWeb @Delightend @faktorsmak - We're getting rid of the product list page, where I was using this, but maybe we want to keep it anyway?

Comment thread less/manta-custom.less Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd use something like (@padding-large-vertical * 2) in place of a hard-coded 20px.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it matter that it's "margin" vs. "padding"? And won't that affect margin-top also? Or is @padding-large-vertical just "10" and it can be applied however?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the margin/padding matters, it really just means "spacing". It's equal to "10px" and it can be used for whatever you want (appropriately).

@tandrewnichols
Copy link
Copy Markdown
Author

I'm actually wondering if we should put a media query inside the main .columnal-list declaration for small screens that basically does nothing. On a regular screen where you want 2 or more columns, you probably still only want 1 on small viewports.

@EddieCanales
Copy link
Copy Markdown

I'd agree that something like that makes sense, but we're getting close to replicating the grid system for lists. Let's hold off on going further on this until we really need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants