be able to use a parse a string containing sql queries#2
Merged
manute merged 4 commits intomanute:masterfrom Apr 19, 2022
Cosmian:master
Merged
be able to use a parse a string containing sql queries#2manute merged 4 commits intomanute:masterfrom Cosmian:master
manute merged 4 commits intomanute:masterfrom
Cosmian:master
Conversation
Owner
|
Hey @heavenboy8 , thanks for the PR!! It looks good to me! |
manute
approved these changes
Apr 19, 2022
Owner
|
I think we need some CI stuff to validate PRs if you intend to do more, if that's the case pls let me know 👍🏽 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With that version, we can parse a string containing SQL queries.
Doing that, we are now able to load the sql file at compile-time using
include_str!(myfile)and therefore it makes our binary independent from the sql file at run-time.Killing two birds with one stone: the code is now compliant with new rust standards.