Implement "OnPhysGunPull" output in CPhysicsProp #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbabf
requested changes
Jan 12, 2024
Collaborator
arbabf
left a comment
arbabf
left a comment
There was a problem hiding this comment.
It seems like pullDir isn't being used here at all, and could probably be removed.
Author
|
made the requested change, pullDir was indeed not being used and I removed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new output allows mappers to fire events when a physics prop is "pulled" by the gravity gun (secondary fire from afar).
PR Checklist
developbranch OR targets another branch with a specific goal in mind