Fix tilesize calculation #39
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, changing the namespace to kartotherian after unresponsive time from the upstream
WMDE-Fisch
added a commit
to wikimedia/abaculus
that referenced
this pull request
Nov 10, 2022
Including tests. See kartotherian:abaculus and mapbox#39
This was referenced Nov 10, 2022
|
I created an updated PR that's based on the current master. I guess this here can be abandoned. See #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way it is calculated makes abaculus work only for scale = 1.
Also, changing the test case with an example easier to check and to reflect the new calculations.
The inputs are the same as the following:
https://maps.wikimedia.org/img/osm-intl,5,-24.405,-47.368,250x250.png
The tile outputs are the following:
https://maps.wikimedia.org/osm-intl/5/11/17.png
https://maps.wikimedia.org/osm-intl/5/12/17.png
https://maps.wikimedia.org/osm-intl/5/11/18.png
https://maps.wikimedia.org/osm-intl/5/12/18.png