This repository was archived by the owner on Oct 30, 2021. It is now read-only.
Closed
Conversation
Contributor
Author
|
It sounds like, from @ingalls and @apendleton, this change was not a cause for bugs downstream. So, closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts part of #126 because I'm worried it could be, despite all unit test passing here in carmen-cache, cause a regression in results. The concern would be that the prefiltering throws out results which might not be thrown out after the 40 context limit later on in the coalescing.
The original motivation of this change was to increase performance by reducing the number of results that needed to be sorted internally.
This PR is intended to help test whether this change could potentially be a source of regressions in desirable results so we can have quick data to consider the tradeoffs of perf and results quality.