Change default logger level to ERROR; Migrate publishing script to SDK registry #65
Conversation
DzmitryFomchyn
force-pushed
the
df-logger-level
branch
2 times, most recently
from
ba354e4 to
be6993a
Compare
DzmitryFomchyn
force-pushed
the
df-logger-level
branch
4 times, most recently
from
def075a to
76ac330
Compare
LukasPaczos
left a comment
LukasPaczos
left a comment
There was a problem hiding this comment.
Thanks a lot for refreshing the publishing scripts! We'll need to update the readme as well to mention the need to use a downloads access token.
| @LogLevel | ||
| @Volatile | ||
| var logLevel: Int = VERBOSE | ||
| var logLevel: Int = NONE |
There was a problem hiding this comment.
Wondering if this should happen here, or rather be changed in the Common SDK and controlled via com.mapbox.common.LogConfiguration#setFilterLevel which developers have access to. All our logs, even from the platform SDKs, should ideally be wired through the Common SDK.
Normally, developers shouldn't interact with this logger instance directly and var logLevel is not part of the Logger interface anyway.
There was a problem hiding this comment.
Common SDK targeting Android should automatically set the CommonSingletonModuleProvider.loggerInstance as the logger backend which I'm not sure if it does already.
There was a problem hiding this comment.
Also, imo, we should also keep logging errors
There was a problem hiding this comment.
Common SDK targeting Android should automatically set the CommonSingletonModuleProvider.loggerInstance as the logger backend which I'm not sure if it does already.
You are right, Common SDK doesn't use base Logger. I've opened a follow-up issue to fix that https://github.com/mapbox/mapbox-sdk-common/issues/2346. We've discussed this with Lukas in DM and decided that we should fix default logging level in this repo and also, logging in the Common SDK.
Also, imo, we should also keep logging errors
Agree, we can leave errors logging by default. I've changed log level to ERROR.
DzmitryFomchyn
force-pushed
the
df-logger-level
branch
from
76ac330 to
7e13b0d
Compare
DzmitryFomchyn
changed the title
Good catch, thanks Lukas, I've added a README note about credentials. |
tobrun
left a comment
tobrun
left a comment
There was a problem hiding this comment.
tremendous effort for a 1 line change :D
3 participants
Closes https://github.com/mapbox/mapbox-sdk-common/issues/2212