Skip to content

Remove MapboxModuleType.NavigationRouter #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DSamaryan merged 1 commit into from
Mar 26, 2024
Merged

Remove MapboxModuleType.NavigationRouter #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions annotations/src/main/java/com/mapbox/annotation/module/MapboxModuleType.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,6 @@ enum class MapboxModuleType(

/* ----- NAVIGATION MODULES ----- */

/**
* Main router used by the Navigation SDK.
*/
@Deprecated("Core Navigation Framework doesn't use a custom router implementation so it will not overwrite the built-in router in Core Navigation Framework anymore")
NavigationRouter("Router", "com.mapbox.navigation.base.route", "Router"),

/**
* Foreground service notification displayed when navigation's trip session is started.
*/
Expand Down
3 changes: 0 additions & 3 deletions examples/src/test/java/com/mapbox/common/examples/ModuleProviderTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,6 @@ class ModuleProviderTest {
MapboxModuleType.CommonLogger -> arrayOf(
ModuleProviderArgument(TripNotification::class.java, MapboxModuleProvider.createModule(MapboxModuleType.NavigationTripNotification, ::paramsProvider))
)
MapboxModuleType.NavigationRouter -> arrayOf(
ModuleProviderArgument(LibraryLoader::class.java, MapboxModuleProvider.createModule(MapboxModuleType.CommonLibraryLoader, ::paramsProvider))
)
MapboxModuleType.NavigationTripNotification -> arrayOf()
MapboxModuleType.MapTelemetry -> arrayOf()
}
Expand Down