removed CommonHttpClient module #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiryldz
reviewed
Apr 3, 2024
| We are introducing build system modularization to enable customization of Mapbox SDKs with minimal binary size overhead and to increase the overall separation of responsibilities across SDKs. The goal is to enable swapping SDK modules during compilation instead of exposing runtime configuration options and relying on third-party tools to remove unused code. | ||
|
|
||
| We streamline independent units of code as much as possible into SDK modules, described by transparent contracts (interfaces). For example, Mapbox SDKs typically have a networking module where the default implementation is OkHttp. The developer can replace the default implementation with a custom implementation without resulting in the SDK bundling unnecessary code, i.e., code for the default implementation is removed. | ||
| We streamline independent units of code as much as possible into SDK modules, described by transparent contracts (interfaces). For example, Mapbox SDKs typically have a native lib loading module with its default implementation. The developer can replace the default implementation with a custom implementation without resulting in the SDK bundling unnecessary code, i.e., code for the default implementation is removed. |
There was a problem hiding this comment.
It's a bit hard for me to believe that the user could replace native lib loading with custom implementation and something will work... It was rather clear with replacing networking module (at least for me) but what's the sense of replacing LibraryLoader?
Author
There was a problem hiding this comment.
This is just an example of how the concept works, not necessarily a suggestion that it should be replaced. What can actually be replaced should be documented by each SDK independently.
kiryldz
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.