This repository was archived by the owner on Aug 8, 2023. It is now read-only.
add polygonal offline region support #5707
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The added deserialization features will be necessary for persisting offline polygon regions.
…d size Calling code may not want to or know how to specify a world size; in these cases, the TransformState should just use its own.
This inverse of fromLatLng will be used later to test the polygon tile cover code.
It is now possible to calculate the tile coverage of arbitrary polygons (including ones with holes). The implementation treats (0,0) as the polygon's center.
There is now a way to create and persist offline storage regions other than the old tile pyramids. The region type is now a variant, and the two options are the old tile pyramids, and a new type for polygons. Each type is an instantiation of a class template for offline regions with fixed geometry.
|
@rosecodym, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jfirebaugh, @brunoabinader and @kkaefer to be potential reviewers |
Contributor
|
Replaced by #11267 and followups to come. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added here is the capability to calculate tile coverage of arbitrary polygonal areas in addition to the basic bounding boxes that were already supported, as well as an additional offline region definition to support polygonal regions. (See #4106) The offline region definition hierarchy has been fiddled with a bit to enable this, and should be easily expandable to future region types, such as ones generated from linear features.