Skip to content

Make model constructors more consistent #441

@cammace

Description

@cammace

We provide constructors for many of our API model classes but the parameters taken in are wildly inconsistent. For example the StepManeuver class provides two constructors:

public StepManeuver() {
  }

  public StepManeuver(String type, String modifier, Integer exit) {
    this.type = type;
    this.modifier = modifier;
    this.exit = exit;
  }

but we don't have constructors for location, bearingBefore, bearingAfter, or instruction variables. Can we get away with only having empty constructors since we now have setters for all variables @zugaldia?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions