Skip to content

Conversation

@pengdev
Copy link
Member

@pengdev pengdev commented Sep 19, 2019

Resolves #1067 by porting turf-area from TurfJs to java.

@pengdev pengdev added the Turf label Sep 19, 2019
@pengdev pengdev self-assigned this Sep 19, 2019
@pengdev pengdev force-pushed the peng-turf-add-area-method branch from e6e5e3b to 2050654 Compare September 19, 2019 08:34
@pengdev pengdev requested review from langsmith and tobrun September 19, 2019 08:42
@pengdev pengdev force-pushed the peng-turf-add-area-method branch from 612e3b4 to 276e098 Compare September 20, 2019 08:00
@pengdev
Copy link
Member Author

pengdev commented Sep 23, 2019

@langsmith I have marked the pr as since 4.9.0, maybe need to update to 4.10.0 ?

@langsmith
Copy link

Yes, please @pengdev .

@pengdev pengdev force-pushed the peng-turf-add-area-method branch from 276e098 to 0e5e560 Compare September 24, 2019 07:53
@pengdev
Copy link
Member Author

pengdev commented Sep 24, 2019

Yes, please @pengdev .

Thanks, now it's changed to 4.10.0

Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @pengdev! Thank you for porting the test suite and keeping the implementation close to the JS one!

@pengdev pengdev merged commit 9739241 into master Sep 24, 2019
@pengdev pengdev deleted the peng-turf-add-area-method branch September 24, 2019 09:32
@langsmith langsmith mentioned this pull request Jan 8, 2020
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Turf Area method

3 participants