Replaced NotNull with NonNull annotation in TurfConversion class #1092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
cc @Guardiola31337 , who has dealt with this |
tobrun
approved these changes
Dec 17, 2019
pengdev
approved these changes
Dec 17, 2019
Author
|
Would this be considered a SEMVER major change? |
Member
I think we can get away that using that NotNull annotation was a bug |
langsmith
deleted the
ls-removing-notnull-annotation-import-from-turf-conversion
branch
Author
|
@chloekraw , heads up that this is now merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr replaces
NotNulland its import line withNonNull. This fixes a bug that has shown up downstream in many of Mapbox's own projects as well as our customers' work.