-
Notifications
You must be signed in to change notification settings - Fork 117
Extract refresh models into separate module #1107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
df74421 to
e5a3d26
Compare
LukasPaczos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any duplicated auto value classes generated when building the /services module?
See
mapbox-java/services/build.gradle
Lines 25 to 32 in 1a932c1
| // Required because the autovalue picks up and generates duplicate class for walking options from services-directions-models, | |
| // possibly because they are in the same package as the rest of services-directions. | |
| // Placing them in the same package has been intentional to avoid breaking changes. | |
| tasks.withType(Jar) { jarTask -> | |
| if (!jarTask.name.endsWith("sourcesJar")) { | |
| jarTask.exclude("**/*WalkingOptions*.class") | |
| } | |
| } |
There is no such problem. Checked in mavenLocal |
| api project(":services-core") | ||
| api project(":services-geojson") | ||
| api "com.mapbox.mapboxsdk:mapbox-sdk-directions-models:5.1.0-SNAPSHOT" | ||
| api project(":services-directions-models") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we should keep adding the explicit dependency until it's released. Same for services-directions-refresh-models cc @LukasPaczos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, I think that's correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still want to keep it as explicit dependency?
@LukasPaczos @Guardiola31337
44e82ab to
fd4944a
Compare
|
Bintray repo is available here https://bintray.com/mapbox/mapbox/mapbox-sdk-directions-refresh-models. |
e0a747f to
3b42d47
Compare
5d9e634 to
7b4ceb0
Compare
7b4ceb0 to
3b42d47
Compare
efab3e2 to
81f1b13
Compare
LukasPaczos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
This PR introduces one more module with DTOs for Direction Refresh API