Skip to content

Conversation

@evabishchevich
Copy link
Contributor

This PR introduces one more module with DTOs for Direction Refresh API

Copy link
Contributor

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any duplicated auto value classes generated when building the /services module?
See

// Required because the autovalue picks up and generates duplicate class for walking options from services-directions-models,
// possibly because they are in the same package as the rest of services-directions.
// Placing them in the same package has been intentional to avoid breaking changes.
tasks.withType(Jar) { jarTask ->
if (!jarTask.name.endsWith("sourcesJar")) {
jarTask.exclude("**/*WalkingOptions*.class")
}
}

@evabishchevich
Copy link
Contributor Author

evabishchevich commented Jan 23, 2020

Are there any duplicated auto value classes generated when building the /services module?
See

// Required because the autovalue picks up and generates duplicate class for walking options from services-directions-models,
// possibly because they are in the same package as the rest of services-directions.
// Placing them in the same package has been intentional to avoid breaking changes.
tasks.withType(Jar) { jarTask ->
if (!jarTask.name.endsWith("sourcesJar")) {
jarTask.exclude("**/*WalkingOptions*.class")
}
}

There is no such problem. Checked in mavenLocal

api project(":services-core")
api project(":services-geojson")
api "com.mapbox.mapboxsdk:mapbox-sdk-directions-models:5.1.0-SNAPSHOT"
api project(":services-directions-models")
Copy link
Contributor

@Guardiola31337 Guardiola31337 Jan 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should keep adding the explicit dependency until it's released. Same for services-directions-refresh-models cc @LukasPaczos

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, I think that's correct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want to keep it as explicit dependency?
@LukasPaczos @Guardiola31337

@evabishchevich evabishchevich force-pushed the ev-split-refresh-models branch 3 times, most recently from 44e82ab to fd4944a Compare January 23, 2020 14:36
@LukasPaczos
Copy link
Contributor

Bintray repo is available here https://bintray.com/mapbox/mapbox/mapbox-sdk-directions-refresh-models.

@evabishchevich evabishchevich force-pushed the ev-split-refresh-models branch 4 times, most recently from e0a747f to 3b42d47 Compare January 23, 2020 15:04
@Guardiola31337 Guardiola31337 force-pushed the ev-split-refresh-models branch 4 times, most recently from 5d9e634 to 7b4ceb0 Compare January 23, 2020 19:36
@evabishchevich evabishchevich force-pushed the ev-split-refresh-models branch from 7b4ceb0 to 3b42d47 Compare January 24, 2020 08:44
@evabishchevich evabishchevich force-pushed the ev-split-refresh-models branch 2 times, most recently from efab3e2 to 81f1b13 Compare January 24, 2020 10:10
Copy link
Contributor

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@evabishchevich evabishchevich merged commit 2dd9638 into master Jan 24, 2020
@LukasPaczos LukasPaczos deleted the ev-split-refresh-models branch January 24, 2020 10:28
@Guardiola31337 Guardiola31337 mentioned this pull request Jan 24, 2020
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants