Skip to content

Add toBuilder() method #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
korshaknn merged 1 commit into from
Jan 23, 2020
Merged

Add toBuilder() method #1110

korshaknn merged 1 commit into from
Jan 23, 2020

Conversation

@korshaknn
Copy link
Contributor

@korshaknn korshaknn commented Jan 23, 2020

Only RouteOptions and WalkingOptions don't have toBuilder() method.

@korshaknn korshaknn requested review from a team, Guardiola31337 and LukasPaczos January 23, 2020 12:26
@korshaknn korshaknn self-assigned this Jan 23, 2020
@korshaknn korshaknn force-pushed the knn-add-to-builder-method branch from 40d9d4f to 0bc528a Compare January 23, 2020 12:36
@korshaknn korshaknn force-pushed the knn-add-to-builder-method branch from 0bc528a to e5de902 Compare January 23, 2020 13:06
LukasPaczos
LukasPaczos approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@korshaknn korshaknn merged commit 7c24920 into master Jan 23, 2020
@korshaknn korshaknn deleted the knn-add-to-builder-method branch January 23, 2020 13:32
@LukasPaczos LukasPaczos mentioned this pull request Jan 23, 2020
Merged
@Guardiola31337 Guardiola31337 mentioned this pull request Jan 24, 2020
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Guardiola31337 Guardiola31337 Awaiting requested review from Guardiola31337

2 more reviewers

@RingerJK RingerJK RingerJK approved these changes

@LukasPaczos LukasPaczos LukasPaczos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@korshaknn korshaknn

Labels

refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@korshaknn @RingerJK @LukasPaczos